Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 74002: Adding HTML5 DB support to Chromium, part 4 of 4: enable DB support. (Closed)

Created:
11 years, 8 months ago by dumi
Modified:
9 years, 7 months ago
Reviewers:
michaeln, jorlow, jam, dglazkov
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adding HTML5 DB support to Chromium, part 4 of 4: enable DB support. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19860

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M DEPS View 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.gyp View 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dglazkov
This looks good, except for the file name in WebCore.vcproj -- SQLiteVfsChromiumWin.
11 years, 8 months ago (2009-04-17 17:52:03 UTC) #1
michaeln
On 2009/04/17 17:52:03, Dimitri Glazkov wrote: > This looks good, except for the file name ...
11 years, 8 months ago (2009-04-17 18:06:44 UTC) #2
dglazkov
Ooh. This brings up a whole slew of questions. Which SQLiteFileSystem flavor will we run ...
11 years, 8 months ago (2009-04-17 21:26:07 UTC) #3
dglazkov
LGTM++.
11 years, 5 months ago (2009-06-29 20:01:12 UTC) #4
jorlow
11 years, 5 months ago (2009-07-02 21:46:38 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698