Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 7400030: Disable part of InProcessBrowserTest.InjectIDBKey to prepare for upstream changes. (Closed)

Created:
9 years, 5 months ago by zarko
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disable part of InProcessBrowserTest.InjectIDBKey to prepare for upstream changes. InProcessBrowserTest.InjectIDBKey depends on internal details about the format produced by WebSerializedScriptValue; this format will change should https://bugs.webkit.org/show_bug.cgi?id=63481 land. After the WebKit change is complete, this test will be re-enabled in a way that works with the new format. BUG=None TEST=This is a test modification. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93053

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/idbbindingutilities_browsertest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
zarko
9 years, 5 months ago (2011-07-18 21:12:28 UTC) #1
zarko
9 years, 5 months ago (2011-07-18 21:15:53 UTC) #2
dgrogan
LGTM after TODO nit http://codereview.chromium.org/7400030/diff/1/chrome/browser/idbbindingutilities_browsertest.cc File chrome/browser/idbbindingutilities_browsertest.cc (right): http://codereview.chromium.org/7400030/diff/1/chrome/browser/idbbindingutilities_browsertest.cc#newcode341 chrome/browser/idbbindingutilities_browsertest.cc:341: // TODO: re-enable this after ...
9 years, 5 months ago (2011-07-18 21:35:40 UTC) #3
zarko
Thanks for the quick response! http://codereview.chromium.org/7400030/diff/1/chrome/browser/idbbindingutilities_browsertest.cc File chrome/browser/idbbindingutilities_browsertest.cc (right): http://codereview.chromium.org/7400030/diff/1/chrome/browser/idbbindingutilities_browsertest.cc#newcode341 chrome/browser/idbbindingutilities_browsertest.cc:341: // TODO: re-enable this ...
9 years, 5 months ago (2011-07-18 21:42:15 UTC) #4
dgrogan
LGTM
9 years, 5 months ago (2011-07-18 21:48:19 UTC) #5
commit-bot: I haz the power
Presubmit check for 7400030-2002 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 5 months ago (2011-07-18 22:51:31 UTC) #6
levin
9 years, 5 months ago (2011-07-18 22:53:36 UTC) #7
On 2011/07/18 22:51:31, I haz the power (commit-bot) wrote:
> Presubmit check for 7400030-2002 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> If this change has an associated bug, add BUG=[bug number].
> 
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
> 
> ** Presubmit Warnings **
> mailto:lukezarko@gmail.com is not in AUTHORS file. If you are a new
contributor, please
> visit
> http://www.chromium.org/developers/contributing-code and read the "Legal"
> section
> If you are a chromite, verify the contributor signed the CLA.

I'll land this.

Powered by Google App Engine
This is Rietveld 408576698