Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Side by Side Diff: src/x64/cpu-x64.cc

Issue 7400023: fix -Wunused-but-set-variable for gcc-4.6 on x64 (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 60
61 // If flushing of the instruction cache becomes necessary Windows has the 61 // If flushing of the instruction cache becomes necessary Windows has the
62 // API function FlushInstructionCache. 62 // API function FlushInstructionCache.
63 63
64 // By default, valgrind only checks the stack for writes that might need to 64 // By default, valgrind only checks the stack for writes that might need to
65 // invalidate already cached translated code. This leads to random 65 // invalidate already cached translated code. This leads to random
66 // instability when code patches or moves are sometimes unnoticed. One 66 // instability when code patches or moves are sometimes unnoticed. One
67 // solution is to run valgrind with --smc-check=all, but this comes at a big 67 // solution is to run valgrind with --smc-check=all, but this comes at a big
68 // performance cost. We can notify valgrind to invalidate its cache. 68 // performance cost. We can notify valgrind to invalidate its cache.
69 #ifdef VALGRIND_DISCARD_TRANSLATIONS 69 #ifdef VALGRIND_DISCARD_TRANSLATIONS
70 VALGRIND_DISCARD_TRANSLATIONS(start, size); 70 (void)VALGRIND_DISCARD_TRANSLATIONS(start, size);
71 #endif 71 #endif
72 } 72 }
73 73
74 74
75 void CPU::DebugBreak() { 75 void CPU::DebugBreak() {
76 #ifdef _MSC_VER 76 #ifdef _MSC_VER
77 // To avoid Visual Studio runtime support the following code can be used 77 // To avoid Visual Studio runtime support the following code can be used
78 // instead 78 // instead
79 // __asm { int 3 } 79 // __asm { int 3 }
80 __debugbreak(); 80 __debugbreak();
81 #else 81 #else
82 asm("int $3"); 82 asm("int $3");
83 #endif 83 #endif
84 } 84 }
85 85
86 } } // namespace v8::internal 86 } } // namespace v8::internal
87 87
88 #endif // V8_TARGET_ARCH_X64 88 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698