Implement setting the length of FixedDoubleArrays.

test/mjsunit/unbox-double-arrays.js

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 10 matching lines @@
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Test dictionary -> double elements -> dictionary elements round trip
 
 // Flags: --allow-natives-syntax --unbox-double-arrays --expose-gc
-var large_array_size = 500000;
+var large_array_size = 100000;
 var approx_dict_to_elements_threshold = 69000;
 
 var name = 0;
 
 function expected_array_value(i) {
   if ((i % 2) == 0) {
     return i;
   } else {
     return i + 0.5;
   }
 }
 
 function force_to_fast_double_array(a) {
+  a[large_array_size - 1] = 1;
   for (var i= 0; i < approx_dict_to_elements_threshold; ++i ) {
     a[i] = expected_array_value(i);
   }
   assertTrue(%HasFastDoubleElements(a));
 }
 
 function flush_compiled_code() {
   gc();
 }
 
+function make_object_like_array(size) {
+  obj = new Object();
+  obj.length = size;
+  return obj;
+}
+
 function testOneArrayType(allocator) {
-  var large_array = new allocator(500000);
+  var large_array = new allocator(large_array_size);
   force_to_fast_double_array(large_array);
 
   for (var i= 0; i < approx_dict_to_elements_threshold; i += 501 ) {
     assertEquals(expected_array_value(i), large_array[i]);
   }
 
   // Multiple versions of the test function makes sure that IC/Crankshaft state
   // doesn't get reused.
   function test_various_loads(a, value_5, value_6, value_7) {
     assertTrue(%HasFastDoubleElements(a));
     assertEquals(value_5, a[5]);
     assertEquals(value_6, a[6]);
     assertEquals(value_7, a[7]);
-    assertEquals(undefined, a[large_array_size-1]);
+    assertEquals(undefined, a[large_array_size-2]);
     assertEquals(undefined, a[-1]);
     assertEquals(large_array_size, a.length);
     assertTrue(%HasFastDoubleElements(a));
   }
 
   function test_various_loads2(a, value_5, value_6, value_7) {
     assertTrue(%HasFastDoubleElements(a));
     assertEquals(value_5, a[5]);
     assertEquals(value_6, a[6]);
     assertEquals(value_7, a[7]);
-    assertEquals(undefined, a[large_array_size-1]);
+    assertEquals(undefined, a[large_array_size-2]);
     assertEquals(undefined, a[-1]);
     assertEquals(large_array_size, a.length);
     assertTrue(%HasFastDoubleElements(a));
   }
 
   function test_various_loads3(a, value_5, value_6, value_7) {
     assertTrue(%HasFastDoubleElements(a));
     assertEquals(value_5, a[5]);
     assertEquals(value_6, a[6]);
     assertEquals(value_7, a[7]);
-    assertEquals(undefined, a[large_array_size-1]);
+    assertEquals(undefined, a[large_array_size-2]);
     assertEquals(undefined, a[-1]);
     assertEquals(large_array_size, a.length);
     assertTrue(%HasFastDoubleElements(a));
   }
 
   function test_various_loads4(a, value_5, value_6, value_7) {
     assertTrue(%HasFastDoubleElements(a));
     assertEquals(value_5, a[5]);
     assertEquals(value_6, a[6]);
     assertEquals(value_7, a[7]);
-    assertEquals(undefined, a[large_array_size-1]);
+    assertEquals(undefined, a[large_array_size-2]);
     assertEquals(undefined, a[-1]);
     assertEquals(large_array_size, a.length);
     assertTrue(%HasFastDoubleElements(a));
   }
 
   function test_various_loads5(a, value_5, value_6, value_7) {
     assertTrue(%HasFastDoubleElements(a));
     assertEquals(value_5, a[5]);
     assertEquals(value_6, a[6]);
     assertEquals(value_7, a[7]);
-    assertEquals(undefined, a[large_array_size-1]);
+    assertEquals(undefined, a[large_array_size-2]);
     assertEquals(undefined, a[-1]);
     assertEquals(large_array_size, a.length);
     assertTrue(%HasFastDoubleElements(a));
   }
 
   function test_various_loads6(a, value_5, value_6, value_7) {
     assertTrue(%HasFastDoubleElements(a));
     assertEquals(value_5, a[5]);
     assertEquals(value_6, a[6]);
     assertEquals(value_7, a[7]);
-    assertEquals(undefined, a[large_array_size-1]);
+    assertEquals(undefined, a[large_array_size-2]);
     assertEquals(undefined, a[-1]);
     assertEquals(large_array_size, a.length);
     assertTrue(%HasFastDoubleElements(a));
   }
 
   function test_various_stores(a, value_5, value_6, value_7) {
     assertTrue(%HasFastDoubleElements(a));
     a[5] = value_5;
     a[6] = value_6;
     a[7] = value_7;
@@ skipping 174 matching lines @@
   test_various_stores(large_array,
                       Infinity,
                       -Infinity,
                       expected_array_value(7));
 
   test_various_loads6(large_array,
                       Infinity,
                       -Infinity,
                       expected_array_value(7));
 
+  // Test apply
   assertTrue(%GetOptimizationStatus(test_various_stores) != 2);
-
-  // Make sure that we haven't converted from fast double.
-  assertTrue(%HasFastDoubleElements(large_array));
-  // Cause the array to grow beyond it's JSArray length. This will double the
-  // size of the capacity and force the array into "slow" dictionary case.
-  large_array[large_array_size+1] = 50;
-  assertTrue(%HasDictionaryElements(large_array));
-  assertEquals(50, large_array[large_array_size+1]);
-  assertEquals(large_array_size+2, large_array.length);
-  assertEquals(Infinity, large_array[5]);
-  assertEquals(undefined, large_array[large_array_size-1]);
-  assertEquals(undefined, large_array[-1]);
-  assertEquals(large_array_size+2, large_array.length);
-
-  // Test dictionary -> double elements -> fast elements.
-  var large_array2 = new allocator(large_array_size);
-  force_to_fast_double_array(large_array2);
-  delete large_array2[5];
-
-  // Convert back to fast elements and make sure the contents of the array are
-  // unchanged.
-  large_array2[25] = new Object();
-  assertTrue(%HasFastElements(large_array2));
-  for (var i= 0; i < approx_dict_to_elements_threshold; i += 500 ) {
-    if (i != 25 && i != 5) {
-      assertEquals(expected_array_value(i), large_array2[i]);
-    }
-  }
-  assertEquals(undefined, large_array2[5])
-      assertEquals(undefined, large_array2[large_array_size-1])
-      assertEquals(undefined, large_array2[-1])
-      assertEquals(large_array_size, large_array2.length);
 }
 
+testOneArrayType(make_object_like_array);
 testOneArrayType(Array);
+
+var large_array = new Array(large_array_size);
+force_to_fast_double_array(large_array);
+assertTrue(%HasFastDoubleElements(large_array));
+
+// Cause the array to grow beyond it's JSArray length. This will double the
+// size of the capacity and force the array into "slow" dictionary case.
+large_array[5] = Infinity;
+large_array[large_array_size+10001] = 50;
+assertTrue(%HasDictionaryElements(large_array));
+assertEquals(50, large_array[large_array_size+10001]);
+assertEquals(large_array_size+10002, large_array.length);
+assertEquals(Infinity, large_array[5]);
+assertEquals(undefined, large_array[large_array_size-2]);
+assertEquals(undefined, large_array[-1]);
+assertEquals(large_array_size+10002, large_array.length);
+
+// Test dictionary -> double elements -> fast elements.
+var large_array2 = new Array(large_array_size);
+force_to_fast_double_array(large_array2);
+delete large_array2[5];
+
+// Convert back to fast elements and make sure the contents of the array are
+// unchanged.
+large_array2[25] = new Object();
+assertTrue(%HasFastElements(large_array2));
+for (var i= 0; i < approx_dict_to_elements_threshold; i += 500 ) {
+  if (i != 25 && i != 5) {
+    assertEquals(expected_array_value(i), large_array2[i]);
+  }
+}
+assertEquals(undefined, large_array2[5]);
+assertEquals(undefined, large_array2[large_array_size-2]);
+assertEquals(undefined, large_array2[-1]);
+assertEquals(large_array_size, large_array2.length);
+
+// Make sure it's possible to change the array's length and that array is still
+// intact after the resize.
+var large_array3 = new Array(large_array_size);
+force_to_fast_double_array(large_array3);
+large_array3.length = 60000;
+assertEquals(60000, large_array3.length);
+assertEquals(undefined, large_array3[60000]);
+assertTrue(%HasFastDoubleElements(large_array3));
+assertEquals(expected_array_value(5), large_array3[5]);
+assertEquals(expected_array_value(6), large_array3[6]);
+assertEquals(expected_array_value(7), large_array3[7]);

[Mads Ager (chromium), 2011/07/19 09:23:06]

Test the element at "length - 1"?

[danno, 2011/07/19 15:47:19]

Done.

+assertEquals(undefined, large_array3[large_array_size-2]);
+assertEquals(undefined, large_array3[-1]);
+
+large_array3.length = 25;
+assertEquals(25, large_array3.length);
+assertTrue(%HasFastDoubleElements(large_array3));
+assertEquals(undefined, large_array3[25]);
+assertEquals(expected_array_value(5), large_array3[5]);
+assertEquals(expected_array_value(6), large_array3[6]);
+assertEquals(expected_array_value(7), large_array3[7]);
+assertEquals(undefined, large_array3[large_array_size-2]);
+assertEquals(undefined, large_array3[-1]);
+
+large_array3.length = 100;
+assertEquals(100, large_array3.length);
+large_array3[95] = 95;
+assertTrue(%HasFastDoubleElements(large_array3));
+assertEquals(undefined, large_array3[100]);
+assertEquals(95, large_array3[95]);
+assertEquals(expected_array_value(5), large_array3[5]);
+assertEquals(expected_array_value(6), large_array3[6]);
+assertEquals(expected_array_value(7), large_array3[7]);
+assertEquals(undefined, large_array3[large_array_size-2]);
+assertEquals(undefined, large_array3[-1]);