Implement setting the length of FixedDoubleArrays.

Implement setting the length property for FixedDoubleArrays.

R=ager@chromium.org
BUG=none
TEST=none

Committed: http://code.google.com/p/v8/source/detail?r=8683

[danno, 2011-07-19 07:55:20]

Please review.

[Mads Ager (chromium), 2011-07-19 09:23:05]

http://codereview.chromium.org/7400020/diff/4001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7400020/diff/4001/src/objects.cc#newcode7575
src/objects.cc:7575: FixedArray::OffsetOfElementAt(value);
Shouldn't this be FixedDoubleArray::OffsetOfElementAt to not have the filler zap
the middle instead of the end of the elements array?

http://codereview.chromium.org/7400020/diff/4001/test/mjsunit/unbox-double-ar...
File test/mjsunit/unbox-double-arrays.js (right):

http://codereview.chromium.org/7400020/diff/4001/test/mjsunit/unbox-double-ar...
test/mjsunit/unbox-double-arrays.js:379: assertEquals(expected_array_value(7),
large_array3[7]);
Test the element at "length - 1"?

[danno, 2011-07-19 15:47:19]

Please take another look.

http://codereview.chromium.org/7400020/diff/4001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7400020/diff/4001/src/objects.cc#newcode7575
src/objects.cc:7575: FixedArray::OffsetOfElementAt(value);
Oh, heavens. Good catch. Done.
On 2011/07/19 09:23:06, Mads Ager wrote:
> Shouldn't this be FixedDoubleArray::OffsetOfElementAt to not have the filler
zap
> the middle instead of the end of the elements array?

http://codereview.chromium.org/7400020/diff/4001/test/mjsunit/unbox-double-ar...
File test/mjsunit/unbox-double-arrays.js (right):

http://codereview.chromium.org/7400020/diff/4001/test/mjsunit/unbox-double-ar...
test/mjsunit/unbox-double-arrays.js:379: assertEquals(expected_array_value(7),
large_array3[7]);
On 2011/07/19 09:23:06, Mads Ager wrote:
> Test the element at "length - 1"?

Done.

[Mads Ager (chromium), 2011-07-19 15:50:06]

LGTM