Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 7400016: Fixed confusion between AST IDs and condition codes on ARM. (Closed)

Created:
9 years, 5 months ago by Sven Panne
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fixed confusion between AST IDs and condition codes on ARM. C++'s 'great' idea of implicitly converting an enum to an integral value hit us again, this time resulting in silly (but currently non-harmful) entries in the relocation table. Encapsulated the AST ID recording a bit, which helped a lot to find the culprit. Committed: http://code.google.com/p/v8/source/detail?r=8671

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +12 lines, -2 lines 0 comments Download
M src/arm/assembler-arm.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
9 years, 5 months ago (2011-07-18 07:57:42 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/7400016/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/7400016/diff/1/src/arm/macro-assembler-arm.cc#newcode200 src/arm/macro-assembler-arm.cc:200: ASSERT_EQ(CallSize(code, rmode, ast_id, cond), SizeOfCodeGeneratedSince(&start)); Long line.
9 years, 5 months ago (2011-07-18 08:43:09 UTC) #2
Sven Panne
9 years, 5 months ago (2011-07-18 09:03:19 UTC) #3
http://codereview.chromium.org/7400016/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/7400016/diff/1/src/arm/macro-assembler-arm.cc#...
src/arm/macro-assembler-arm.cc:200: ASSERT_EQ(CallSize(code, rmode, ast_id,
cond), SizeOfCodeGeneratedSince(&start));
On 2011/07/18 08:43:09, Mads Ager wrote:
> Long line.

Done.

Powered by Google App Engine
This is Rietveld 408576698