Issue 7400003: Start the extension event routers for each profile, not just at browser startup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7400003: Start the extension event routers for each profile, not just at browser startup. (Closed)

Created:
9 years, 5 months ago by Yoyo Zhou

Modified:
9 years, 5 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Start the extension event routers for each profile, not just at browser startup. Fix browser event router's browser notification registration profile check. Original review at http://codereview.chromium.org/6976030 BUG=84059 TEST=sync_integration_tests don't crash this time Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92929

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -11 lines)			Patch
M	chrome/browser/browser_main.cc	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/extension_browser_event_router.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Miranda Callahan

9 years, 5 months ago (2011-07-18 14:27:17 UTC) #2

On 2011/07/15 21:03:13, Yoyo Zhou wrote:

Wow, that was a simple change -- nice, LGTM!