Issue 7399023: Pass isolate to AST ID functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7399023: Pass isolate to AST ID functions. (Closed)

Created:
9 years, 5 months ago by Vitaly Repeshko

Modified:
9 years, 5 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Pass isolate to AST ID functions. R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8678

Patch Set 1 #

Total comments: 1

Patch Set 2 : A bit less ugly #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+336 lines, -211 lines)			Patch
M	src/ast.h	View		38 chunks	+134 lines, -66 lines	0 comments	Download
M	src/ast.cc	View		7 chunks	+40 lines, -28 lines	0 comments	Download
M	src/ast-inl.h	View		1 chunk	+32 lines, -24 lines	0 comments	Download
M	src/parser.h	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/parser.cc	View	1	52 chunks	+106 lines, -78 lines	0 comments	Download
M	src/rewriter.cc	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	src/scopes.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/scopes.cc	View	1	6 chunks	+8 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 5 months ago (2011-07-18 16:44:10 UTC) #2

LGTM(isolate())

http://codereview.chromium.org/7399023/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/7399023/diff/1/src/parser.cc#newcode4139
src/parser.cc:4139: new(zone()) CallRuntime(isolate(),
Whoa! Can we pull out the CallRuntime construction and name that?

Expand Messages | Collapse Messages