Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: Source/WebCore/ChangeLog

Issue 7398032: Merge 90599 - Work around Skia PDF's lack of inverted path support. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/782/
Patch Set: Fixing ChangeLog entry. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 91206)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,3 +1,24 @@
+2011-07-07 Steve VanDeBogart <vandebo@chromium.org>
+
+ Work around Skia PDF's lack of inverted path support.
+ https://bugs.webkit.org/show_bug.cgi?id=64032
+
+ Reviewed by James Robinson.
+
+ The trick used in http://neugierig.org/software/chromium/notes/2010/07/clipping.html
+ to support antialiased clips doesn't work when printing to Skia's PDF backend because
+ the backend does not support inverted paths. This manifests as rounded buttons not being
+ drawn when printing, tracked as Chrome bug 79519.
+
+ However, when the output is a vector device, like PDF, we don't need antialiased clips.
+ It's up to the PDF rendering engine to do that. So we can simply disable the antialiased
+ clip code if the output is a vector device.
+
+ I think the fix isn't testable because it requires examining the printed output.
+
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (WebCore::PlatformContextSkia::clipPathAntiAliased):
+
2011-06-23 John Bates <jbates@google.com>
Reviewed by James Robinson.
« no previous file with comments | « no previous file | Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698