Issue 7398025: Fix live-object-list to work with isolates....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7398025: Fix live-object-list to work with isolates.... (Closed)

Created:
9 years, 5 months ago by shasank.palm

Modified:
9 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Chromium), danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix live-object-list to work with isolates. TEST: Build v8 with live-object-list enabled. Committed: http://code.google.com/p/v8/source/detail?r=8940

Patch Set 1 #

Total comments: 3

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -80 lines)			Patch
	M	src/liveobjectlist.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/liveobjectlist.cc	View		46 chunks	+116 lines, -78 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

shasank.palm_gmail.com

This patch is being submitted on behalf of Alexander Miller at HP.

9 years, 5 months ago (2011-07-18 08:51:35 UTC) #1

danno

9 years, 4 months ago (2011-08-16 11:42:17 UTC) #2

LGTM, with a couple of tiny stylistic nits that I fixed before landing.

http://codereview.chromium.org/7398025/diff/1/src/liveobjectlist.cc
File src/liveobjectlist.cc (right):

http://codereview.chromium.org/7398025/diff/1/src/liveobjectlist.cc#newcode42
src/liveobjectlist.cc:42: #include "isolate.h"
nit: please alphabetize includes.

http://codereview.chromium.org/7398025/diff/1/src/liveobjectlist.cc#newcode1566
src/liveobjectlist.cc:1566: factory->NewJSObject(isolate->object_function());
indent 4

http://codereview.chromium.org/7398025/diff/1/src/liveobjectlist.cc#newcode1666
src/liveobjectlist.cc:1666:
static_cast<int>(StringToInt(isolate->unicode_cache(), *address, 16));
nit: indentation -> 4 spaces

Expand Messages | Collapse Messages