Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 7397010: Prepare push to trunk. (Closed)

Created:
9 years, 5 months ago by Sven Panne
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Committed: http://code.google.com/p/v8/source/detail?r=8668

Patch Set 1 #

Total comments: 12

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M ChangeLog View 1 1 chunk +30 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
9 years, 5 months ago (2011-07-18 09:00:44 UTC) #1
Mads Ager (chromium)
LGTM Lots of comments on the ChangeLog. Most (or all) can be ignored if you ...
9 years, 5 months ago (2011-07-18 09:16:56 UTC) #2
Sven Panne
9 years, 5 months ago (2011-07-18 09:35:14 UTC) #3
http://codereview.chromium.org/7397010/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode1
ChangeLog:1: 2011-07-18: Version 3.4.13
Conclusion after some offline discussions: Announce removal of this file in the
mailing list.

http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode3
ChangeLog:3: Support scope information and evaluation in optimized frames (issue
On 2011/07/18 09:16:56, Mads Ager wrote:
> Maybe write that this is improved debugger support to allow inspection of
> optimized frames? 

Done.

http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode8
ChangeLog:8: Implemented ICs for FastDoubleArray loads and stores for ia32, x64
and
On 2011/07/18 09:16:56, Mads Ager wrote:
> This is not turned on by default, so I would leave out this line.

Done.

http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode17
ChangeLog:17: Exposed APIs for detecting boxed primitives, native errors and
Math.
On 2011/07/18 09:16:56, Mads Ager wrote:
> The Math part did not land and is handled differently.

Done.

http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode26
ChangeLog:26: Implemented delete trap for proxies (issue 1543).
On 2011/07/18 09:16:56, Mads Ager wrote:
> Not on by default, so I would delete this line.

Done.

http://codereview.chromium.org/7397010/diff/1/ChangeLog#newcode33
ChangeLog:33: initialization. (chrome issue 89462).
On 2011/07/18 09:16:56, Mads Ager wrote:
> chrome -> chromium.

Done.

Powered by Google App Engine
This is Rietveld 408576698