Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7397004: Take two at splitting result codes between content and chrome. (Closed)

Created:
9 years, 5 months ago by Dirk Pranke
Modified:
9 years, 5 months ago
CC:
chromium-reviews, tfarina, Erik does not do reviews, brettw-cc_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Take two at splitting result codes between content and chrome. content/common/result_codes.h contains only the codes defined in content. chrome/common/chrome_result_codes.h contains the codes defined in chrome and also includes (for convenience) the content header. R=jam@chromium.org BUG=76699 TEST=everything compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93082

Patch Set 1 #

Patch Set 2 : rebase to head?? #

Patch Set 3 : fix compile failure in uninstall.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -141 lines) Patch
M chrome/app/breakpad_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/chrome_exe_main_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/client_util.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/app/dummy_main_functions.cc View 1 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/browser_main.cc View 13 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/browser_main_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_main_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_main_win.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_function.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/first_run/first_run_import_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/hang_monitor/hung_window_detector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/web_cache_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A chrome/common/chrome_result_codes.h View 1 chunk +78 lines, -0 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 2 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/nacl/nacl_main.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/service/service_child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chrome_process_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_message_filter.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/handle_enumerator_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/browser_render_process_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/zygote_host_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/zygote_main_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/process_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/result_codes.h View 1 chunk +14 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
9 years, 5 months ago (2011-07-18 19:18:59 UTC) #1
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 5 months ago (2011-07-18 19:20:40 UTC) #2
jam
lgtm
9 years, 5 months ago (2011-07-18 19:26:02 UTC) #3
commit-bot: I haz the power
9 years, 5 months ago (2011-07-18 20:41:32 UTC) #4 
Try job failure for 7397004-1039 (previous was lost) (retry) on win for step
"compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698