Issue 7396026: Consolidate content-security-policy markup

Issue 7396026: Consolidate content-security-policy markup (Closed)

Created:
9 years, 5 months ago by Tom Sepez

Modified:
9 years, 5 months ago

Reviewers:
abarth-chromium, Evan Stade

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), Randy Smith (Not in Mondays)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Consolidate content-security-policy markup for chrome:// pages into a single file, and have grit preprocess it into all the places it belongs. Also add to resource bundle so that the about handler can return the same thing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93052

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -104 lines)			Patch
M	chrome/browser/browser_about_handler.cc	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/about_conflicts.html	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/resources/about_flash.html	View		1 chunk	+1 line, -8 lines	0 comments	Download
M	chrome/browser/resources/about_memory.html	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/about_memory_linux.html	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	chrome/browser/resources/about_memory_mac.html	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/about_stats.html	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	chrome/browser/resources/about_version.html	View		1 chunk	+1 line, -6 lines	0 comments	Download
A	chrome/browser/resources/content_security_policy.html	View	1	1 chunk	+14 lines, -0 lines	2 comments	Download
M	chrome/browser/resources/crashes.html	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/resources/downloads.html	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	chrome/browser/resources/extensions_ui.html	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/resources/flags.html	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	chrome/browser/resources/history.html	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	chrome/browser/resources/options/options.html	View	1	1 chunk	+1 line, -9 lines	0 comments	Download
M	chrome/browser/resources/plugins.html	View		1 chunk	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Yay! http://codereview.chromium.org/7396026/diff/1/chrome/browser/resources/content_security_policy.html File chrome/browser/resources/content_security_policy.html (right): http://codereview.chromium.org/7396026/diff/1/chrome/browser/resources/content_security_policy.html#newcode9 chrome/browser/resources/content_security_policy.html:9: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief We probably show add a comment explain ...

9 years, 5 months ago (2011-07-18 18:52:35 UTC) #2

Tom Sepez

http://codereview.chromium.org/7396026/diff/1/chrome/browser/resources/content_security_policy.html File chrome/browser/resources/content_security_policy.html (right): http://codereview.chromium.org/7396026/diff/1/chrome/browser/resources/content_security_policy.html#newcode9 chrome/browser/resources/content_security_policy.html:9: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief On 2011/07/18 18:52:35, abarth wrote: > We probably ...

9 years, 5 months ago (2011-07-18 19:00:17 UTC) #3

Evan Stade

lgtm http://codereview.chromium.org/7396026/diff/4001/chrome/browser/resources/content_security_policy.html File chrome/browser/resources/content_security_policy.html (right): http://codereview.chromium.org/7396026/diff/4001/chrome/browser/resources/content_security_policy.html#newcode1 chrome/browser/resources/content_security_policy.html:1: <!-- X-WebKit-CSP is our development name for Content-Security-Policy. ...

9 years, 5 months ago (2011-07-19 01:08:41 UTC) #4

Tom Sepez

9 years, 5 months ago (2011-07-19 16:51:02 UTC) #5

http://codereview.chromium.org/7396026/diff/4001/chrome/browser/resources/con...
File chrome/browser/resources/content_security_policy.html (right):

http://codereview.chromium.org/7396026/diff/4001/chrome/browser/resources/con...
chrome/browser/resources/content_security_policy.html:1: <!-- X-WebKit-CSP is
our development name for Content-Security-Policy.
On 2011/07/19 01:08:42, Evan Stade wrote:
> license header?

Done.

Expand Messages | Collapse Messages