Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 7396025: Refactor Instant web UI (chrome://settings page). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: New approach (keep checkbox tied to pref) Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/pref_ui.js
diff --git a/chrome/browser/resources/options/pref_ui.js b/chrome/browser/resources/options/pref_ui.js
index 16af4d0231cbca3ba89434fb804a25f074865f43..fe7c51a57c77812a10140d63aa5b2785a2caf7e5 100644
--- a/chrome/browser/resources/options/pref_ui.js
+++ b/chrome/browser/resources/options/pref_ui.js
@@ -98,6 +98,8 @@ cr.define('options', function() {
this.addEventListener(
'change',
function(e) {
+ if (self.customChangeHandler && self.customChangeHandler(e))
Evan Stade 2011/07/25 23:01:34 if you make this a function of PrefCheckbox that h
sreeram 2011/07/25 23:56:42 Done.
+ return;
var value = self.inverted_pref ? !self.checked : self.checked;
switch(self.valueType) {
case 'number':

Powered by Google App Engine
This is Rietveld 408576698