Refactor Instant web UI (chrome://settings page).

chrome/browser/resources/options/pref_ui.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var Preferences = options.Preferences;
 
   /**
    * Allows an element to be disabled for several reasons.
@@ skipping 80 matching lines @@
             else
               self.checked = Boolean(value);
 
             updateElementState_(self, event);
           });
 
       // Listen to user events.
       this.addEventListener(
           'change',
           function(e) {
+            if (self.customChangeHandler && self.customChangeHandler(e))

[Evan Stade, 2011/07/25 23:01:34]

if you make this a function of PrefCheckbox that has a default stub
implementation that just returns false, then you won't have to check if it
exists and (more importantly) you will have a place to add documentation.

[sreeram, 2011/07/25 23:56:42]

Done.

+              return;
             var value = self.inverted_pref ? !self.checked : self.checked;
             switch(self.valueType) {
               case 'number':
                 Preferences.setIntegerPref(self.pref,
                     Number(value), self.metric);
                 break;
               case 'boolean':
                 Preferences.setBooleanPref(self.pref,
                     value, self.metric);
                 break;
@@ skipping 587 matching lines @@
     PrefNumber: PrefNumber,
     PrefNumeric: PrefNumeric,
     PrefRadio: PrefRadio,
     PrefRange: PrefRange,
     PrefSelect: PrefSelect,
     PrefTextField: PrefTextField,
     PrefButton: PrefButton
   };
 
 });