Refactor Instant web UI (chrome://settings page).

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   const OptionsPage = options.OptionsPage;
   const ArrayDataModel = cr.ui.ArrayDataModel;
 
   //
   // BrowserOptions class
@@ skipping 53 matching lines @@
         chrome.send('toggleShowBookmarksBar');
       };
       $('defaultSearchManageEnginesButton').onclick = function(event) {
         OptionsPage.navigateToPage('searchEngines');
         chrome.send('coreOptionsUserMetricsAction',
             ['Options_ManageSearchEngines']);
       };
       $('defaultSearchEngine').onchange = this.setDefaultSearchEngine_;
 
       var self = this;
-      $('instantEnableCheckbox').onclick = function(event) {
-        if (this.checked && !self.instantConfirmDialogShown_) {
-          // Leave disabled for now. The PrefCheckbox handler already set it to
-          // true so undo that.
-          Preferences.setBooleanPref(this.pref, false, this.metric);
-          OptionsPage.navigateToPage('instantConfirm');
+      $('instantEnabledCheckbox').customChangeHandler = function(event) {
+        if (this.checked) {
+          if (self.instantConfirmDialogShown_) {

[Evan Stade, 2011/07/25 23:01:34]

nit: no curlies

[sreeram, 2011/07/25 23:56:42]

Done.

+            chrome.send('enableInstant');
+          } else {
+            OptionsPage.navigateToPage('instantConfirm');
+          }
+        } else {
+          chrome.send('disableInstant');
         }
+        return true;
       };
 
       Preferences.getInstance().addEventListener('instant.confirm_dialog_shown',
           this.onInstantConfirmDialogShownChanged_.bind(this));
 
       var homepageField = $('homepageURL');
       $('homepageUseNTPButton').onchange =
           this.handleHomepageUseNTPButtonChange_.bind(this);
       $('homepageUseURLButton').onchange =
           this.handleHomepageUseURLButtonChange_.bind(this);
@@ skipping 394 matching lines @@
   BrowserOptions.updateAutocompleteSuggestions = function(suggestions) {
     BrowserOptions.getInstance().updateAutocompleteSuggestions_(suggestions);
   };
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 
 });