Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 7396022: Revert "Make GYP build usable for day-to-day work" (Closed)

Created:
9 years, 5 months ago by Jakob Kummerow
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert "Make GYP build usable for day-to-day work" This reverts r8674 due to failures on the buildbots. Committed: http://code.google.com/p/v8/source/detail?r=8677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -555 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
D Makefile View 1 chunk +0 lines, -110 lines 0 comments Download
M build/all.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M build/armu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 2 chunks +4 lines, -18 lines 0 comments Download
M build/v8-features.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
D preparser/preparser.gyp View 1 chunk +0 lines, -41 lines 0 comments Download
M samples/samples.gyp View 2 chunks +9 lines, -10 lines 0 comments Download
M src/d8.gyp View 3 chunks +2 lines, -17 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/testcfg.py View 2 chunks +2 lines, -11 lines 0 comments Download
M test/preparser/testcfg.py View 1 chunk +1 line, -6 lines 0 comments Download
M tools/gyp/v8.gyp View 20 chunks +67 lines, -93 lines 0 comments Download
M tools/test.py View 3 chunks +0 lines, -9 lines 0 comments Download
D tools/test-wrapper-gypbuild.py View 1 chunk +0 lines, -223 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
:-(
9 years, 5 months ago (2011-07-18 16:37:00 UTC) #1
Mads Ager (chromium)
9 years, 5 months ago (2011-07-18 16:37:58 UTC) #2
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698