Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: build/linux/system.gyp

Issue 7396013: Linux: revive a mysteriously disabled test and add tests for the GNOME Keyring native backend. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/linux/system.gyp
===================================================================
--- build/linux/system.gyp (revision 92796)
+++ build/linux/system.gyp (working copy)
@@ -379,6 +379,38 @@
],
},
{
+ 'target_name': 'gnome-keyring-direct',
Evan Martin 2011/07/18 15:31:00 I think we normally use underscores for these name
Mike Mammarella 2011/07/19 00:20:35 Done.
+ 'type': 'settings',
Evan Martin 2011/07/18 15:31:00 It turns out this type actually doesn't exist in g
Mike Mammarella 2011/07/19 00:20:35 So, I changed this, and then the unit tests stoppe
+ 'conditions': [
+ ['use_gnome_keyring==1', {
+ 'direct_dependent_settings': {
+ 'cflags': [
+ '<!@(<(pkg-config) --cflags gnome-keyring-1)',
+ ],
+ 'defines': [
+ 'USE_GNOME_KEYRING',
+ ],
+ 'conditions': [
+ ['linux_link_gnome_keyring==0', {
+ 'defines': ['DLOPEN_GNOME_KEYRING'],
+ }],
+ ],
+ },
+ # The unit tests use a few convenience functions from the GNOME
+ # Keyring library directly. We ignore linux_link_gnome_keyring and
+ # link directly in this version of the target to allow this.
+ 'link_settings': {
+ 'ldflags': [
+ '<!@(<(pkg-config) --libs-only-L --libs-only-other gnome-keyring-1)',
+ ],
+ 'libraries': [
+ '<!@(<(pkg-config) --libs-only-l gnome-keyring-1)',
+ ],
+ },
+ }],
+ ],
+ },
+ {
'target_name': 'dbus-glib',
'type': 'settings',
'direct_dependent_settings': {

Powered by Google App Engine
This is Rietveld 408576698