Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 7395030: Correctly mark functions from our natives files during compilation. (Closed)

Created:
9 years, 5 months ago by Mads Ager (chromium)
Modified:
9 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Correctly mark functions from our natives files during compilation. When creating a CompilationInfo we always have the script and can determine if it is a natives script. Now that all natives functions are recognized as such, many of them are called with undefined as the receiver. We have to use different filtering for builtins functions when printing stack traces. Also, fixed one call of CALL_NON_FUNCTION to be correctly marked as a method call (with fixed receiver). Now that CALL_NON_FUNCTION is marked as a native function this caused the receiver to be undefined. R=svenpanne@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -20 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.h View 1 chunk +6 lines, -3 lines 0 comments Download
M src/compiler.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/messages.js View 1 chunk +9 lines, -7 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 2 chunks +22 lines, -7 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-798.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Sven Panne
9 years, 5 months ago (2011-07-19 08:08:47 UTC) #1
LGTM

Powered by Google App Engine
This is Rietveld 408576698