Issue 7395012: Introduce a random entropy source which can optionally be provided at initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7395012: Introduce a random entropy source which can optionally be provided at initialization. (Closed)

Created:
9 years, 5 months ago by Cris Neckar

Modified:
9 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), Chris Evans, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Introduce a random entropy source which can optionally be provided at initialization. BUG=89462 Committed: http://code.google.com/p/v8/source/detail?r=8666

Patch Set 1 : '' #

Total comments: 3

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -2 lines)			Patch
M	include/v8.h	View	2 chunks	+13 lines, -0 lines	1 comment	Download
M	src/api.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/v8.h	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	src/v8.cc	View	3 chunks	+16 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM, I'll land it. http://codereview.chromium.org/7395012/diff/10/include/v8.h File include/v8.h (right): http://codereview.chromium.org/7395012/diff/10/include/v8.h#newcode2807 include/v8.h:2807: * of cryptographically safe entropy. ...

9 years, 5 months ago (2011-07-17 08:59:12 UTC) #2

Mads Ager (chromium)

9 years, 5 months ago (2011-07-17 09:11:39 UTC) #3

http://codereview.chromium.org/7395012/diff/10/src/v8.cc
File src/v8.cc (right):

http://codereview.chromium.org/7395012/diff/10/src/v8.cc#newcode108
src/v8.cc:108: if (FLAG_random_seed != NULL)
Please consistently use braces around the body. Also, FLAG_random_seem is not a
pointer but an int, so the test should be '0' instead of 'NULL'. I'll fix these
too.

Expand Messages | Collapse Messages