Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Side by Side Diff: src/objects.cc

Issue 7391001: Implement sealing, freezing, and related functions for proxies. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing Mads' comments, plus bug fix. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | src/runtime.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2283 matching lines...) Expand 10 before | Expand all | Expand 10 after
2294 Handle<Object> result = 2294 Handle<Object> result =
2295 Execution::Call(trap, handler, ARRAY_SIZE(args), args, has_exception); 2295 Execution::Call(trap, handler, ARRAY_SIZE(args), args, has_exception);
2296 if (has_exception) return NONE; 2296 if (has_exception) return NONE;
2297 2297
2298 // TODO(rossberg): convert result to PropertyAttributes 2298 // TODO(rossberg): convert result to PropertyAttributes
2299 USE(result); 2299 USE(result);
2300 return NONE; 2300 return NONE;
2301 } 2301 }
2302 2302
2303 2303
2304 void JSProxy::Fix() {
2305 Isolate* isolate = GetIsolate();
2306 HandleScope scope(isolate);
2307 Handle<JSProxy> self(this);
2308
2309 isolate->factory()->BecomeJSObject(self);
2310 ASSERT(IsJSObject());
Vyacheslav Egorov (Chromium) 2011/07/19 04:07:57 self->IsJSObject() as we have GC above
rossberg 2011/07/20 09:11:09 Done.
2311 // TODO(rossberg): recognize function proxies.
2312 }
2313
2314
2315
2304 MaybeObject* JSObject::SetPropertyForResult(LookupResult* result, 2316 MaybeObject* JSObject::SetPropertyForResult(LookupResult* result,
2305 String* name, 2317 String* name,
2306 Object* value, 2318 Object* value,
2307 PropertyAttributes attributes, 2319 PropertyAttributes attributes,
2308 StrictModeFlag strict_mode) { 2320 StrictModeFlag strict_mode) {
2309 Heap* heap = GetHeap(); 2321 Heap* heap = GetHeap();
2310 // Make sure that the top context does not change when doing callbacks or 2322 // Make sure that the top context does not change when doing callbacks or
2311 // interceptor calls. 2323 // interceptor calls.
2312 AssertNoContextChange ncc; 2324 AssertNoContextChange ncc;
2313 2325
(...skipping 9438 matching lines...) Expand 10 before | Expand all | Expand 10 after
11752 if (break_point_objects()->IsUndefined()) return 0; 11764 if (break_point_objects()->IsUndefined()) return 0;
11753 // Single beak point. 11765 // Single beak point.
11754 if (!break_point_objects()->IsFixedArray()) return 1; 11766 if (!break_point_objects()->IsFixedArray()) return 1;
11755 // Multiple break points. 11767 // Multiple break points.
11756 return FixedArray::cast(break_point_objects())->length(); 11768 return FixedArray::cast(break_point_objects())->length();
11757 } 11769 }
11758 #endif 11770 #endif
11759 11771
11760 11772
11761 } } // namespace v8::internal 11773 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | src/runtime.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698