Generating separate version resources for:

chrome/app/chrome_exe.rc

Index: chrome/app/chrome_exe.rc
===================================================================
--- chrome/app/chrome_exe.rc	(revision 92932)
+++ chrome/app/chrome_exe.rc	(working copy)
@@ -11,8 +11,6 @@
 #include "windows.h"
 #undef APSTUDIO_HIDDEN_SYMBOLS
 
-/////////////////////////////////////////////////////////////////////////////
-#undef APSTUDIO_READONLY_SYMBOLS

[cpu_(ooo_6.6-7.5), 2011/07/19 21:43:13]

why does line 15 goes away but not line 5? It seems that if the thing works
without the whole 5-12 block it would be best.

[bradn, 2011/07/19 21:59:47]

Eh, actually I clopped it off by mistake.
I'm inclined to put it back (as that matches chrome.dll)?

 
 /////////////////////////////////////////////////////////////////////////////
 // English (U.S.) resources
@@ -24,38 +22,8 @@
 #endif //_WIN32
 
 
-#ifdef APSTUDIO_INVOKED
 /////////////////////////////////////////////////////////////////////////////
 //
-// TEXTINCLUDE
-//
-
-1 TEXTINCLUDE
-BEGIN
-    "chrome_exe_resource.h\0"
-END
-
-2 TEXTINCLUDE
-BEGIN
-    "#define APSTUDIO_HIDDEN_SYMBOLS\r\n"
-    "#include ""windows.h""\r\n"
-    "#undef APSTUDIO_HIDDEN_SYMBOLS\r\n"
-    "\0"
-END
-
-3 TEXTINCLUDE
-BEGIN
-    "\r\n"
-    "\0"
-END
-
-#else    // APSTUDIO_INVOKED
-#include "chrome_exe_version.rc"

[cpu_(ooo_6.6-7.5), 2011/07/19 21:39:56]

so we no longer use the include of line 53?

[bradn, 2011/07/19 21:59:47]

Made this match chrome_dll, where we include that rc file directly as a source
file. See chrome_exe.gypi

-#endif   // APSTUDIO_INVOKED
-
-
-/////////////////////////////////////////////////////////////////////////////
-//
 // Icon
 //
 
@@ -77,14 +45,3 @@
 
 #endif    // English (U.S.) resources
 /////////////////////////////////////////////////////////////////////////////
-
-
-#ifndef APSTUDIO_INVOKED
-/////////////////////////////////////////////////////////////////////////////
-//
-// Generated from the TEXTINCLUDE 3 resource.
-//
-
-
-/////////////////////////////////////////////////////////////////////////////
-#endif    // not APSTUDIO_INVOKED