Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7390037: Generating separate version resources for: (Closed)

Created:
9 years, 5 months ago by bradn
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Generating separate version resources for: chrome.dll chrome.exe nacl64.dll nacl64.exe BUG=http://code.google.com/p/chromium/issues/detail?id=65350 TEST=None R=cpu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93124

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 1

Patch Set 7 : '' #

Total comments: 6

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -202 lines) Patch
A chrome/app/chrome_dll.ver View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
D chrome/app/chrome_dll_version.rc.version View 1 2 3 4 5 6 7 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/app/chrome_exe.rc View 1 2 3 4 5 6 7 2 chunks +0 lines, -41 lines 0 comments Download
A chrome/app/chrome_exe.ver View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
D chrome/app/chrome_exe_version.rc.version View 1 2 3 4 5 6 7 1 chunk +0 lines, -40 lines 0 comments Download
A + chrome/app/chrome_version.rc.version View 1 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/app/nacl64_dll.ver View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/app/nacl64_exe.ver View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/app/other.ver View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 6 7 2 chunks +15 lines, -6 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 4 5 6 7 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 4 5 6 7 6 chunks +9 lines, -42 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 15 chunks +17 lines, -17 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bradn
9 years, 5 months ago (2011-07-18 20:15:00 UTC) #1
bradn
Ping? On Mon, Jul 18, 2011 at 1:15 PM, <bradnelson@google.com> wrote: > Reviewers: cpu, > ...
9 years, 5 months ago (2011-07-19 16:53:04 UTC) #2
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/7390037/diff/11001/chrome/app/chrome_exe_version.rc.version File chrome/app/chrome_exe_version.rc.version (left): http://codereview.chromium.org/7390037/diff/11001/chrome/app/chrome_exe_version.rc.version#oldcode25 chrome/app/chrome_exe_version.rc.version:25: VALUE "FileVersion", "0.0.0.0" can we haz the real version ...
9 years, 5 months ago (2011-07-19 21:24:04 UTC) #3
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/7390037/diff/15001/chrome/app/chrome_exe.rc File chrome/app/chrome_exe.rc (left): http://codereview.chromium.org/7390037/diff/15001/chrome/app/chrome_exe.rc#oldcode53 chrome/app/chrome_exe.rc:53: #include "chrome_exe_version.rc" so we no longer use the include ...
9 years, 5 months ago (2011-07-19 21:39:56 UTC) #4
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/7390037/diff/15001/chrome/app/chrome_exe.rc File chrome/app/chrome_exe.rc (left): http://codereview.chromium.org/7390037/diff/15001/chrome/app/chrome_exe.rc#oldcode15 chrome/app/chrome_exe.rc:15: #undef APSTUDIO_READONLY_SYMBOLS why does line 15 goes away but ...
9 years, 5 months ago (2011-07-19 21:43:12 UTC) #5
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/7390037/diff/15001/chrome/app/chrome_exe_version.rc.version File chrome/app/chrome_exe_version.rc.version (left): http://codereview.chromium.org/7390037/diff/15001/chrome/app/chrome_exe_version.rc.version#oldcode30 chrome/app/chrome_exe_version.rc.version:30: VALUE "ProductVersion", "0.0.0.0" still 0.0.0 ?
9 years, 5 months ago (2011-07-19 21:52:24 UTC) #6
bradn
PTAL http://codereview.chromium.org/7390037/diff/15001/chrome/app/chrome_exe.rc File chrome/app/chrome_exe.rc (left): http://codereview.chromium.org/7390037/diff/15001/chrome/app/chrome_exe.rc#oldcode15 chrome/app/chrome_exe.rc:15: #undef APSTUDIO_READONLY_SYMBOLS On 2011/07/19 21:43:13, cpu wrote: > ...
9 years, 5 months ago (2011-07-19 21:59:47 UTC) #7
cpu_(ooo_6.6-7.5)
ah sorry yes deleting is good. LGTM
9 years, 5 months ago (2011-07-19 22:07:57 UTC) #8
commit-bot: I haz the power
9 years, 5 months ago (2011-07-19 22:14:38 UTC) #9 
Can't process patch for file chrome/app/chrome_version.rc.version.
A  +

Powered by Google App Engine
This is Rietveld 408576698