Issue 7390032: Fixes regression from menu refactoring. The old windows code wasn't

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7390032: Fixes regression from menu refactoring. The old windows code wasn't (Closed)

Created:
9 years, 5 months ago by sky

Modified:
9 years, 5 months ago

Reviewers:
oshima

CC:
chromium-reviews, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixes regression from menu refactoring. The old windows code wasn't correctly listening to capture change, so that once I wired it up it exposed a bug. I need to suppress capture change notification when hiding a menu, otherwise it prematurely triggers cancelling menus. BUG=89594 TEST=see bug, also covered by automated tests now. R=oshima@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93029

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename field #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -6 lines)			Patch
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc	View		1 chunk	+44 lines, -0 lines	0 comments	Download
M	views/controls/menu/menu_host.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/controls/menu/menu_host.cc	View	1	4 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

oshima

LGTM with a nit. http://codereview.chromium.org/7390032/diff/1/views/controls/menu/menu_host.h File views/controls/menu/menu_host.h (right): http://codereview.chromium.org/7390032/diff/1/views/controls/menu/menu_host.h#newcode77 views/controls/menu/menu_host.h:77: bool showing_or_hiding_; Looking at how ...

9 years, 5 months ago (2011-07-18 18:18:04 UTC) #2

sky

9 years, 5 months ago (2011-07-18 21:43:28 UTC) #3

http://codereview.chromium.org/7390032/diff/1/views/controls/menu/menu_host.h
File views/controls/menu/menu_host.h (right):

http://codereview.chromium.org/7390032/diff/1/views/controls/menu/menu_host.h...
views/controls/menu/menu_host.h:77: bool showing_or_hiding_;
On 2011/07/18 18:18:04, oshima wrote:
> Looking at how this is used, i think "ignore_capture_lost_" or something like
is
> easier to understand. What do you think?

Done.

Expand Messages | Collapse Messages