Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/runtime.js

Issue 7390028: Implement `in' for proxies. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing Mads' comments. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 function DELETE(key, strict) { 347 function DELETE(key, strict) {
348 return %DeleteProperty(%ToObject(this), %ToString(key), strict); 348 return %DeleteProperty(%ToObject(this), %ToString(key), strict);
349 } 349 }
350 350
351 351
352 // ECMA-262, section 11.8.7, page 54. 352 // ECMA-262, section 11.8.7, page 54.
353 function IN(x) { 353 function IN(x) {
354 if (!IS_SPEC_OBJECT(x)) { 354 if (!IS_SPEC_OBJECT(x)) {
355 throw %MakeTypeError('invalid_in_operator_use', [this, x]); 355 throw %MakeTypeError('invalid_in_operator_use', [this, x]);
356 } 356 }
357 return %_IsNonNegativeSmi(this) ? %HasElement(x, this) : %HasProperty(x, %ToSt ring(this)); 357 return %_IsNonNegativeSmi(this) && !%IsJSProxy(x) ?
358 %HasElement(x, this) : %HasProperty(x, %ToString(this));
358 } 359 }
359 360
360 361
361 // ECMA-262, section 11.8.6, page 54. To make the implementation more 362 // ECMA-262, section 11.8.6, page 54. To make the implementation more
362 // efficient, the return value should be zero if the 'this' is an 363 // efficient, the return value should be zero if the 'this' is an
363 // instance of F, and non-zero if not. This makes it possible to avoid 364 // instance of F, and non-zero if not. This makes it possible to avoid
364 // an expensive ToBoolean conversion in the generated code. 365 // an expensive ToBoolean conversion in the generated code.
365 function INSTANCE_OF(F) { 366 function INSTANCE_OF(F) {
366 var V = this; 367 var V = this;
367 if (!IS_FUNCTION(F)) { 368 if (!IS_FUNCTION(F)) {
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
640 throw %MakeTypeError('cannot_convert_to_primitive', []); 641 throw %MakeTypeError('cannot_convert_to_primitive', []);
641 } 642 }
642 643
643 644
644 // NOTE: Setting the prototype for Array must take place as early as 645 // NOTE: Setting the prototype for Array must take place as early as
645 // possible due to code generation for array literals. When 646 // possible due to code generation for array literals. When
646 // generating code for a array literal a boilerplate array is created 647 // generating code for a array literal a boilerplate array is created
647 // that is cloned when running the code. It is essential that the 648 // that is cloned when running the code. It is essential that the
648 // boilerplate gets the right prototype. 649 // boilerplate gets the right prototype.
649 %FunctionSetPrototype($Array, new $Array(0)); 650 %FunctionSetPrototype($Array, new $Array(0));
OLDNEW
« src/objects.cc ('K') | « src/runtime.cc ('k') | test/mjsunit/harmony/proxies.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698