Implement `in' for proxies.

Implement `in' for proxies.

R=ager@chromium.org
BUG=v8:1543
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=8681

[Mads Ager (chromium), 2011-07-19 08:18:04]

LGTM

This is two changes mixed together. Could you upload just the 'in' patch?

http://codereview.chromium.org/7390028/diff/1/src/factory.h
File src/factory.h (right):

http://codereview.chromium.org/7390028/diff/1/src/factory.h#newcode257
src/factory.h:257: void BecomeJSObject(Handle<JSProxy> object);
This is from a previous change?

http://codereview.chromium.org/7390028/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

http://codereview.chromium.org/7390028/diff/1/src/objects-inl.h#newcode4166
src/objects-inl.h:4166: 
Add an extra newline. We usually have two newlines between methods.

http://codereview.chromium.org/7390028/diff/1/test/mjsunit/harmony/proxies.js
File test/mjsunit/harmony/proxies.js (right):

http://codereview.chromium.org/7390028/diff/1/test/mjsunit/harmony/proxies.js...
test/mjsunit/harmony/proxies.js:407: // Element (in).
We should have tests for the case where the Has trap throws an exception.

[rossberg, 2011-07-19 09:29:52]

New upload is diff to master only. Sorry for the mess.

http://codereview.chromium.org/7390028/diff/1/src/factory.h
File src/factory.h (right):

http://codereview.chromium.org/7390028/diff/1/src/factory.h#newcode257
src/factory.h:257: void BecomeJSObject(Handle<JSProxy> object);
On 2011/07/19 08:18:05, Mads Ager wrote:
> This is from a previous change?

Yes, sorry, I keep messing up with Git branches...

http://codereview.chromium.org/7390028/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

http://codereview.chromium.org/7390028/diff/1/src/objects-inl.h#newcode4166
src/objects-inl.h:4166: 
On 2011/07/19 08:18:05, Mads Ager wrote:
> Add an extra newline. We usually have two newlines between methods.

Done.

http://codereview.chromium.org/7390028/diff/1/test/mjsunit/harmony/proxies.js
File test/mjsunit/harmony/proxies.js (right):

http://codereview.chromium.org/7390028/diff/1/test/mjsunit/harmony/proxies.js...
test/mjsunit/harmony/proxies.js:407: // Element (in).
On 2011/07/19 08:18:05, Mads Ager wrote:
> We should have tests for the case where the Has trap throws an exception.

I left that for the TODO at the top, since I still have to add exception cases
to most of the other tests, too.

[Mads Ager (chromium), 2011-07-19 09:35:28]

LGTM

http://codereview.chromium.org/7390028/diff/6002/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7390028/diff/6002/src/objects.cc#newcode2208
src/objects.cc:2208: Handle<Object> trap(v8::internal::GetProperty(handler,
trap_name));
I would use = instead of constructor syntax here.