Added group policies to enable/disable importing of data from other browsers.

chrome/browser/resources/options/import_data_overlay.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
 
   /**
    * ImportDataOverlay class
    * Encapsulated handling of the 'Import Data' overlay page.
    * @class
    */
   function ImportDataOverlay() {
     OptionsPage.call(this,
                      'importData',
                      templateData.importDataOverlayTabTitle,
                      'import-data-overlay');
   }
 
   cr.addSingletonGetter(ImportDataOverlay);
 
   ImportDataOverlay.prototype = {
     // Inherit from OptionsPage.
     __proto__: OptionsPage.prototype,
 
+    import_history_pref: {
+      'name': 'import_history',
+      'value': true,
+      'managed': false
+    },
+
+    import_favorites_pref: {
+      'name': 'import_bookmarks',
+      'value': true,
+      'managed': false
+    },
+
+    import_passwords_pref: {
+      'name': 'import_saved_passwords',
+      'value': true,
+      'managed': false
+    },
+
+    import_search_pref: {
+      'name': 'import_search_engine',
+      'value': true,
+      'managed': false
+    },
+
     /**
      * Initialize the page.
      */
     initializePage: function() {
       // Call base class implementation to start preference initialization.
       OptionsPage.prototype.initializePage.call(this);
 
       var self = this;
       var checkboxes =
           document.querySelectorAll('#import-checkboxes input[type=checkbox]');
       for (var i = 0; i < checkboxes.length; i++) {
         checkboxes[i].onchange = function() {
           self.validateCommitButton_();
         };
       }
 
-      $('import-browsers').onchange = function() {
-        self.updateCheckboxes_();
-        self.validateCommitButton_();
-      };

[simo, 2011/07/19 12:24:47]

just noticed that I removed this by mistake so I'll put this back in with the
other changes.

-
       $('import-data-commit').onclick = function() {
         chrome.send('importData', [
             String($('import-browsers').selectedIndex),
             String($('import-history').checked),
             String($('import-favorites').checked),
             String($('import-passwords').checked),
             String($('import-search').checked)]);
       };
 
       $('import-data-cancel').onclick = function() {
         ImportDataOverlay.dismiss();
       };
 
       $('import-data-show-bookmarks-bar').onchange = function() {
         // Note: The callback 'toggleShowBookmarksBar' is handled within the
         // browser options handler -- rather than the import data handler --
         // as the implementation is shared by several clients.
         chrome.send('toggleShowBookmarksBar');
       }
 
       $('import-data-confirm').onclick = function() {
         ImportDataOverlay.dismiss();
       };
 
+      // Initialize control enabled states.
+      Preferences.getInstance().addEventListener(
+                                self.import_history_pref.name,

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

Indentation should be +4 spaces after a line break

+                                function(event) {
+                                  self.handleImportPrefChange_(
+                                                self.import_history_pref,

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

same here, but it'll probably fit on the previous line if you reindent the block

+                                                event);
+                                  if (this.browserProfiles != undefined) {
+                                    self.updateCheckboxes_();
+                                    self.validateCommitButton_();
+                                  }
+                                });
+      Preferences.getInstance().addEventListener(
+                                self.import_favorites_pref.name,
+                                function(event) {
+                                  self.handleImportPrefChange_(
+                                                self.import_favorites_pref,
+                                                event);
+                                  if (this.browserProfiles != undefined) {
+                                    self.updateCheckboxes_();
+                                    self.validateCommitButton_();
+                                  }
+                                });
+      Preferences.getInstance().addEventListener(
+                                self.import_passwords_pref.name,
+                                function(event) {
+                                  self.handleImportPrefChange_(
+                                                self.import_passwords_pref,
+                                                event);
+                                  if (this.browserProfiles != undefined) {
+                                    self.updateCheckboxes_();
+                                    self.validateCommitButton_();
+                                  }
+                                });
+      Preferences.getInstance().addEventListener(
+                                self.import_search_pref.name,
+                                function(event) {
+                                  self.handleImportPrefChange_(
+                                                self.import_search_pref,
+                                                event);
+                                  if (this.browserProfiles != undefined) {
+                                    self.updateCheckboxes_();
+                                    self.validateCommitButton_();
+                                  }
+                                });
+
       // Form controls are disabled until the profile list has been loaded.
       self.setControlsSensitive_(false);
     },
 
     /**
      * Set enabled and checked state of the commit button.
      * @private
      */
     validateCommitButton_: function() {
       var somethingToImport =
           $('import-history').checked || $('import-favorites').checked ||
           $('import-passwords').checked || $('import-search').checked;
       $('import-data-commit').disabled = !somethingToImport;
     },
 

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

only one blank line

+
+    /**
+     * Returns true if the checkbox should be enabled.
+     * @returns {boolean} Whether the checkbox should be enabled.
+     * @private
+     */
+    shouldEnableCheckbox_: function(checkbox) {
+      if (checkbox == $('import-history'))
+        return !this.import_history_pref.managed;
+      if (checkbox == $('import-favorites'))
+        return !this.import_favorites_pref.managed;
+      if (checkbox == $('import-passwords'))
+        return !this.import_passwords_pref.managed;
+      if (checkbox == $('import-search'))
+        return !this.import_search_pref.managed;
+    },
+
+    /**
+     * Returns true if the checkbox should be enabled.
+     * @returns {boolean} Whether the checkbox should be enabled.
+     * @private
+     */
+    shouldCheckCheckbox_: function(checkbox) {
+      if (checkbox == $('import-history'))
+        return this.import_history_pref.value;
+      if (checkbox == $('import-favorites'))
+        return this.import_favorites_pref.value;
+      if (checkbox == $('import-passwords'))
+        return this.import_passwords_pref.value;
+      if (checkbox == $('import-search'))
+        return this.import_search_pref.value;
+    },
+
     /**
      * Sets the sensitivity of all the checkboxes and the commit button.
      * @private
      */
     setControlsSensitive_: function(sensitive) {
+

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

don't need this blank line.

       var checkboxes =
           document.querySelectorAll('#import-checkboxes input[type=checkbox]');
-      for (var i = 0; i < checkboxes.length; i++)
-        this.setUpCheckboxState_(checkboxes[i], sensitive);
+      for (var i = 0; i < checkboxes.length; i++) {

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

In this block, it might be simpler to just grab the right pref object (maybe
using this.importPrefs[i]) and call a function that will evaluate managed and
value and change the checkbox state.

+          var enabled = this.shouldEnableCheckbox_(checkboxes[i]) && sensitive;

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

+2 space indentation.

+          this.setUpCheckboxState_(checkboxes[i],
+                                   enabled,
+                                   this.shouldCheckCheckbox_(checkboxes[i]));
+      }
       $('import-data-commit').disabled = !sensitive;
     },
 
     /**
      * Set enabled and checked states a checkbox element.
      * @param {Object} checkbox A checkbox element.
      * @param {boolean} enabled The enabled state of the chekbox.
      * @private
      */
-    setUpCheckboxState_: function(checkbox, enabled) {
+    setUpCheckboxState_: function(checkbox, enabled, checked) {
       checkbox.disabled = !enabled;
-      checkbox.checked = enabled;
+      checkbox.checked = checked;
     },
 
     /**
      * Update the enabled and checked states of all checkboxes.
      * @private
      */
     updateCheckboxes_: function() {
       var index = $('import-browsers').selectedIndex;
       var browserProfile;
       if (this.browserProfiles.length > index)
         browserProfile = this.browserProfiles[index];
       var importOptions = ['history', 'favorites', 'passwords', 'search'];
+      var importPrefs = [this.import_history_pref,
+                         this.import_favorites_pref,
+                         this.import_passwords_pref,
+                         this.import_search_pref];
       for (var i = 0; i < importOptions.length; i++) {
         var checkbox = $('import-' + importOptions[i]);
-        this.setUpCheckboxState_(checkbox,
-            browserProfile ? browserProfile[importOptions[i]] : false);
+        var enabled = !importPrefs[i].managed

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

&& goes on this line

+                       && browserProfile[importOptions[i]];
+        var checked = importPrefs[i].value;
+        this.setUpCheckboxState_(checkbox, enabled, checked);
       }
     },
 
     /**
+     * Handles change event of the different import preferences

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

missing period, also 2 lines below.

+     * @param {pref} preference object corresponding to the preference
+     *               that changed
+     * @param {event} change event
+     * @private
+     */
+    handleImportPrefChange_: function(pref, event) {
+      pref.value  = event.value['value'];
+      pref.managed = event.value['managed'];
+    },
+
+    /**
      * Update the supported browsers popup with given entries.
      * @param {array} browsers List of supported browsers name.
      * @private
      */
     updateSupportedBrowsers_: function(browsers) {
       this.browserProfiles = browsers;
       var browserSelect = $('import-browsers');
       browserSelect.remove(0);  // Remove the 'Loading...' option.
       browserSelect.textContent = '';
       var browserCount = browsers.length;
@@ skipping 41 matching lines @@
     }
     $('import-browsers').disabled = state;
     $('import-throbber').style.visibility = state ? "visible" : "hidden";
     ImportDataOverlay.getInstance().validateCommitButton_();
   };
 
   /**
    * Remove the import overlay from display.
    */
   ImportDataOverlay.dismiss = function() {
+    ImportDataOverlay.setImportingState(false);
     OptionsPage.closeOverlay();
   };
 
   /**
    * Show a message confirming the success of the import operation.
    */
   ImportDataOverlay.confirmSuccess = function() {
     var showBookmarksMessage = $('import-favorites').checked;
     ImportDataOverlay.setImportingState(false);
     $('import-data-configure').hidden = true;
     $('import-data-success').hidden = false;
     $('import-find-your-bookmarks').hidden = !showBookmarksMessage;
   };
 
   // Export
   return {
     ImportDataOverlay: ImportDataOverlay
   };
 });