Added group policies to enable/disable importing of data from other browsers.

chrome/browser/first_run/first_run.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/first_run/first_run.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
@@ skipping 81 matching lines @@
     NOTIMPLEMENTED();
 #endif
   }
   return return_code;
 }
 
 // static
 bool FirstRun::ProcessMasterPreferences(const FilePath& user_data_dir,
                                         MasterPrefs* out_prefs) {
   DCHECK(!user_data_dir.empty());
-

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

Please don't remove white space before comments.

   // The standard location of the master prefs is next to the chrome binary.
   FilePath master_prefs;
   if (!PathService::Get(base::DIR_EXE, &master_prefs))
     return true;
   master_prefs = master_prefs.AppendASCII(installer::kDefaultMasterPrefs);
-
   installer::MasterPreferences prefs(master_prefs);
   if (!prefs.read_from_file())
     return true;
 
   out_prefs->new_tabs = prefs.GetFirstRunTabs();
 
   bool value = false;
 
 #if defined(OS_WIN)
   // RLZ is currently a Windows-only phenomenon.  When it comes to the Mac/
@@ skipping 369 matching lines @@
     bool search_engine_experiment,
     bool randomize_search_engine_experiment,
     bool make_chrome_default,
     ProcessSingleton* process_singleton) {
   // We need to avoid dispatching new tabs when we are importing because
   // that will lead to data corruption or a crash. Because there is no UI for
   // the import process, we pass NULL as the window to bring to the foreground
   // when a CopyData message comes in; this causes the message to be silently
   // discarded, which is the correct behavior during the import process.
   process_singleton->Lock(NULL);
-

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

why did you remove this?

   PlatformSetup();
-

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

and this?

   FilePath local_state_path;
   PathService::Get(chrome::FILE_LOCAL_STATE, &local_state_path);
   bool local_state_file_exists = file_util::PathExists(local_state_path);
 
   scoped_refptr<ImporterHost> importer_host;
   // TODO(csilv,mirandac): Out-of-process import has only been qualified on
   // MacOS X, so we will only use it on that platform since it is required.
   // Remove this conditional logic once oop import is qualified for
   // Linux/Windows. http://crbug.com/22142
 #if defined(OS_MACOSX)
@@ skipping 31 matching lines @@
           !local_state_file_exists) {
         items = items | importer::SEARCH_ENGINES;
       }
     } else if (import_items & importer::SEARCH_ENGINES) {
         items = items | importer::SEARCH_ENGINES;
     }
 
     // Bookmarks are never imported, unless turned on in master_preferences.
     if (import_items & importer::FAVORITES)
       items = items | importer::FAVORITES;
 

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

Only one blank line before comments.

+
+    // Write import preferences to user profile if they are not user controlled
+    // in order to get the combination of master_preferences and policy, then
+    // read preferences back out to adjust the items to be imported to reflect
+    // policy

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

Missing period.

[Mattias Nissler (ping if slow), 2011/07/18 15:02:30]

This also means that the default selection in the Import dialog corresponds to
master_preferences, correct? I thought we wanted to keep current behavior of
just selecting all of the checkboxes?

[simo, 2011/07/19 12:24:47]

It does select all the checkboxes if the corresponding policies are disabled. If
any of them are enabled, the corresponding checkbox will be checked/unchecked
according to the value of the policy and greyed out.

[Mattias Nissler (ping if slow), 2011/07/20 09:28:31]

Yes, but what happens if no policy is present? Won't it initialize the
checkboxes to what master_preferences says?

+    PrefService* user_prefs = profile->GetPrefs();
+
+    if (user_prefs->FindPreference(prefs::kImportBookmarks)->IsManaged()) {
+      user_prefs->SetBoolean(prefs::kImportBookmarks,
+                            (items & importer::FAVORITES) != 0);
+
+      if (user_prefs->GetBoolean(prefs::kImportBookmarks))
+        items = items | importer::FAVORITES;
+      else
+        items = items & (~importer::FAVORITES);
+    }
+
+    if (user_prefs->FindPreference(prefs::kImportHistory)->IsManaged()) {
+      user_prefs->SetBoolean(prefs::kImportHistory,
+                             (items & importer::HISTORY) != 0);
+
+      if (user_prefs->GetBoolean(prefs::kImportHistory))
+        items = items | importer::HISTORY;
+      else
+        items = items & (~importer::HISTORY);
+    }
+
+    if (user_prefs->FindPreference(prefs::kImportHomepage)->IsManaged()) {
+      user_prefs->SetBoolean(prefs::kImportHomepage,
+                            (items & importer::HOME_PAGE) != 0);
+
+      if (user_prefs->GetBoolean(prefs::kImportHomepage))
+        items = items | importer::HOME_PAGE;
+      else
+        items = items & (~importer::HOME_PAGE);
+    }
+
+    if (user_prefs->FindPreference(prefs::kImportSearchEngine)->IsManaged()) {
+      user_prefs->SetBoolean(prefs::kImportSearchEngine,
+                            (items & importer::SEARCH_ENGINES) != 0);
+
+      if (user_prefs->GetBoolean(prefs::kImportSearchEngine))
+        items = items | importer::SEARCH_ENGINES;
+      else
+        items = items & (~importer::SEARCH_ENGINES);
+    }
+
     ImportSettings(profile, importer_host, importer_list, items);
   }
 
   UserMetrics::RecordAction(UserMetricsAction("FirstRunDef_Accept"));
 
   // Launch the search engine dialog only for certain builds, and only if the
   // user has not already set preferences.
   if (IsOrganicFirstRun() && !local_state_file_exists) {
     // The home page string may be set in the preferences, but the user should
     // initially use Chrome with the NTP as home page in organic builds.
@@ skipping 85 matching lines @@
   if (!observer->ended()) {
     observer->set_should_quit_message_loop();
     MessageLoop::current()->Run();
   }
 
   // Unfortunately there's no success/fail signal in ImporterHost.
   return true;
 }
 
 #endif  // OS_POSIX