[Mac] Remove the Lion fullscreen button until proper fullscreen support is added.

[Mac] Remove the Lion fullscreen button until proper fullscreen support is added.

BUG=74056, 74065
TEST=Run on Lion. No fullscreen button in upper right.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92728

[Robert Sesek, 2011-07-15 16:25:53]

I can't do a direct revert because BWC and friends have changed a bit resulting
in unclean merges. This is also just a partial revert and leaves in-place the
forward SDK declarations. I wanted to be a surgical as possible to increase the
chances for merging to the branch (though I expect to be rejected...) and
because they'll be needed in the future. Let me know if you think I should
remove those bits, too.

[Mark Mentovai, 2011-07-15 16:28:09]

Which branch do you have in mind? This certainly won’t be going to 12.

http://codereview.chromium.org/7390012/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/7390012/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:542: -
(void)setUpOSFullScreenButton {
Are you sure you don’t want to dump this entirely now? Unlike the forward SDK
declarations, I doubt we’ll use this as-is.

[Robert Sesek, 2011-07-15 16:31:15]

On 2011/07/15 16:28:09, Mark Mentovai wrote:
> Which branch do you have in mind? This certainly won’t be going to 12.

Yeah, 12 is definitely out. 13 is on beta and is getting closer to stable, so I
was hoping that.

>
http://codereview.chromium.org/7390012/diff/1/chrome/browser/ui/cocoa/browser...
> File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):
> 
>
http://codereview.chromium.org/7390012/diff/1/chrome/browser/ui/cocoa/browser...
> chrome/browser/ui/cocoa/browser_window_controller_private.mm:542: -
> (void)setUpOSFullScreenButton {
> Are you sure you don’t want to dump this entirely now? Unlike the forward SDK
> declarations, I doubt we’ll use this as-is.

Since we have a custom window frame, won't we need to set up the OS button
manually again. Only the behavior of the button should be changing...

[Mark Mentovai, 2011-07-15 16:32:22]

LGTM

Yeah, I guess so, we might need this. I forgot about all of that junk we have to
do.