Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 7388009: Canary versions no longer always remove protocol handlers at startup. (Closed)

Created:
9 years, 5 months ago by benwells
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Mike Lawther (Google), koz (OOO until 15th September)
Visibility:
Public.

Description

Canary versions no longer always remove protocol handlers at startup. Canary versions no longer check OS registration at startup as they cannot make themselves the default OS handler. BUG=88196 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92825

Patch Set 1 #

Patch Set 2 : Fixed up comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/custom_handlers/protocol_handler_registry.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/shell_integration.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/shell_integration_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
benwells
9 years, 5 months ago (2011-07-15 06:46:07 UTC) #1
tony
LGTM. Please get it to run on the trybots before landing.
9 years, 5 months ago (2011-07-15 16:37:01 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-07-18 02:25:33 UTC) #3
Change committed as 92825

Powered by Google App Engine
This is Rietveld 408576698