Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 7387011: Clean up the file dev interfaces. The combination of some dev and some non (Closed)

Created:
9 years, 5 months ago by brettw
Modified:
9 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Clean up the file dev interfaces. The combination of some dev and some non dev interfaces in various places makes it impossible to compile some code. This makes the dev versions typedefs which should avoid breaking most (though not all) users. It also converts the file chooser to using the non-dev version of file ref. TEST=it compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92725

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -667 lines) Patch
M ppapi/c/dev/pp_file_info_dev.h View 1 1 chunk +4 lines, -27 lines 0 comments Download
M ppapi/c/dev/ppb_file_io_dev.h View 1 1 chunk +2 lines, -106 lines 0 comments Download
M ppapi/c/dev/ppb_file_ref_dev.h View 1 chunk +2 lines, -68 lines 0 comments Download
M ppapi/c/dev/ppb_file_system_dev.h View 1 chunk +2 lines, -34 lines 0 comments Download
M ppapi/cpp/dev/file_chooser_dev.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/dev/file_chooser_dev.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/cpp/dev/file_io_dev.h View 1 chunk +2 lines, -38 lines 0 comments Download
D ppapi/cpp/dev/file_io_dev.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M ppapi/cpp/dev/file_ref_dev.h View 1 1 chunk +2 lines, -52 lines 0 comments Download
D ppapi/cpp/dev/file_ref_dev.cc View 1 chunk +0 lines, -114 lines 0 comments Download
M ppapi/cpp/dev/file_system_dev.h View 1 1 chunk +2 lines, -18 lines 0 comments Download
D ppapi/cpp/dev/file_system_dev.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M ppapi/examples/file_chooser/file_chooser.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/tests/test_file_io.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_file_io.cc View 31 chunks +43 lines, -43 lines 1 comment Download
M ppapi/tests/test_file_system.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
9 years, 5 months ago (2011-07-15 16:23:25 UTC) #1
piman
drive-by LGTM
9 years, 5 months ago (2011-07-15 16:26:04 UTC) #2
dmichael (off chromium)
+sanga Can we just delete them now? I think NaCl is ready for it, or ...
9 years, 5 months ago (2011-07-15 16:30:10 UTC) #3
dmichael (off chromium)
I'd rather delete them now. but if that's not an option LGTM with green trybots. ...
9 years, 5 months ago (2011-07-15 16:31:46 UTC) #4
sanga
lgtm
9 years, 5 months ago (2011-07-15 16:40:42 UTC) #5
sanga
9 years, 5 months ago (2011-07-15 16:43:42 UTC) #6
Just to avoid breakage if NaCl DEP bumps chrome revision, we should hold off
deleting the dev file interfaces for now until the dependent tests in NaCl and
the NaCl plugin are updated.

Powered by Google App Engine
This is Rietveld 408576698