Adding usage and quota entry to chrome://settings/cookies.

chrome/browser/ui/webui/cookies_tree_model_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/cookies_tree_model_util.h"
 
 #include "base/i18n/time_formatting.h"
 #include "base/string_number_conversions.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
@@ skipping 23 matching lines @@
 static const char kKeyManifest[] = "manifest";
 
 static const char kKeyAccessed[] = "accessed";
 static const char kKeyCreated[] = "created";
 static const char kKeyExpires[] = "expires";
 static const char kKeyModified[] = "modified";
 
 static const char kKeyPersistent[] = "persistent";
 static const char kKeyTemporary[] = "temporary";
 
+static const char kKeyTotalUsage[] = "totalUsage";
+static const char kKeyTemporaryUsage[] = "temporaryUsage";
+static const char kKeyPersistentUsage[] = "persistentUsage";
+static const char kKeyPersistentQuota[] = "persistentQuota";
+
 // Encodes a pointer value into a hex string.
 std::string PointerToHexString(const void* pointer) {
   return base::HexEncode(&pointer, sizeof(pointer));
 }
 
 // Decodes a pointer from a hex string.
 void* HexStringToPointer(const std::string& str) {
   std::vector<uint8> buffer;
   if (!base::HexStringToBytes(str, &buffer) ||
       buffer.size() != sizeof(void*)) {
@@ skipping 129 matching lines @@
                           l10n_util::GetStringUTF8(
                               IDS_COOKIES_FILE_SYSTEM_USAGE_NONE));
       dict->SetString(kKeyTemporary,
                       file_system_info.has_temporary ?
                           UTF16ToUTF8(ui::FormatBytes(
                               file_system_info.usage_temporary)) :
                           l10n_util::GetStringUTF8(
                               IDS_COOKIES_FILE_SYSTEM_USAGE_NONE));
       break;
     }
+    case CookieTreeNode::DetailedInfo::TYPE_QUOTA: {
+      dict->SetString(kKeyType, "quota");
+      dict->SetString(kKeyIcon, "chrome://theme/IDR_COOKIE_STORAGE_ICON");
+
+      const BrowsingDataQuotaHelper::QuotaInfo& quota_info =
+          *node.GetDetailedInfo().quota_info;
+      dict->SetString(kKeyOrigin, quota_info.host);
+      dict->SetString(kKeyTotalUsage,

[Mike Mammarella, 2011/07/29 17:59:26]

In the example screenshot you have some data that's only measured in bytes, so
it shows up as B. I wonder if that's small enough that without the column header
it won't be obvious what it means; KB and MB are more recognizable as sizes.
Maybe if it's less than 1 KB we should omit it?

[tzik, 2011/08/01 02:46:26]

Done.

+                      UTF16ToUTF8(ui::FormatBytes(
+                          quota_info.temporary_usage +
+                          quota_info.persistent_usage)));
+      dict->SetString(kKeyTemporaryUsage,
+                      UTF16ToUTF8(ui::FormatBytes(
+                          quota_info.temporary_usage)));
+      dict->SetString(kKeyPersistentUsage,
+                      UTF16ToUTF8(ui::FormatBytes(
+                          quota_info.persistent_usage)));
+      break;
+    }
     default:
 #if defined(OS_MACOSX)
       dict->SetString(kKeyIcon, "chrome://theme/IDR_BOOKMARK_BAR_FOLDER");
 #endif
       break;
   }
 }
 
 void GetChildNodeList(CookieTreeNode* parent, int start, int count,
                       ListValue* nodes) {
@@ skipping 23 matching lines @@
     if (child_index == -1)
       break;
 
     parent = child;
   }
 
   return child_index >= 0 ? child : NULL;
 }
 
 }  // namespace cookies_tree_model_util