Adding usage and quota entry to chrome://settings/cookies.

chrome/browser/browsing_data_quota_helper.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_BROWSING_DATA_QUOTA_HELPER_H_
+#define CHROME_BROWSER_BROWSING_DATA_QUOTA_HELPER_H_
+#pragma once
+
+#include <string>
+#include <vector>
+
+#include "base/callback_old.h"
+#include "base/memory/ref_counted.h"
+#include "base/time.h"
+#include "content/browser/browser_thread.h"
+#include "webkit/quota/quota_types.h"
+
+class Profile;
+
+namespace quota {
+class QuotaManager;
+}
+
+// This class is an interface class to bridge between Cookies Tree and Unified
+// Quota System.  This class provides a way to get usage and quota information
+// through the instance.
+//
+// Call Create to create an instance for a profile and call StartFetching with
+// a callback to fetch information asynchronously. If result is no longer needed
+// after StartFetching, call CancelNotification to prevent callback.
+//
+// Parallel fetching is not allowed, a fetching task should start after end of
+// previous task.  All method of this class should called from UI thread.
+//
+// QuotaInfo contains host-based quota and usage informations for persistent

[kinuko, 2011/07/25 13:22:41]

nit: should this comment be moved at the definition of QuotaInfo (i.e. between
line 40-41)?

[tzik, 2011/07/26 10:52:41]

Done.

+// and temporary storage.
+class BrowsingDataQuotaHelper
+    : public base::RefCountedThreadSafe<BrowsingDataQuotaHelper,
+                                        BrowserThread::DeleteOnIOThread> {

[kinuko, 2011/07/25 13:22:41]

As we chatted locally, we should either 1) use MessageLoopProxy to delete
instance on the correct thread, or 2) use BrowserThread in the testing code too.

[tzik, 2011/07/26 10:52:41]

Done.
I modified them as 1).
We can easily switch single/multi thread style in unittest with 1).

+ public:
+  struct QuotaInfo {
+    QuotaInfo();
+    explicit QuotaInfo(const std::string& host);
+    QuotaInfo(const std::string& host,
+              int64 temporary_usage,
+              int64 persistent_usage,
+              int64 persistent_quota);
+    ~QuotaInfo();
+
+    std::string host;
+    int64 temporary_usage;
+    int64 persistent_usage;
+    int64 persistent_quota;
+  };
+
+  typedef std::vector<QuotaInfo> QuotaInfoList;
+  typedef Callback1<const QuotaInfoList&>::Type FetchResultCallback;
+
+  static BrowsingDataQuotaHelper* Create(Profile* profile);
+
+  virtual void StartFetching(FetchResultCallback* callback) = 0;
+  virtual void CancelNotification() = 0;
+
+  // We don't support deletion now.
+  virtual void DeleteQuotaHost(const std::string& host) {}
+
+ protected:
+  BrowsingDataQuotaHelper() { }
+  virtual ~BrowsingDataQuotaHelper() { }

[kinuko, 2011/07/25 13:22:41]

no space between { } ?

[tzik, 2011/07/26 10:52:41]

Done.

+
+ private:
+  friend struct BrowserThread::DeleteOnThread<BrowserThread::IO>;
+  friend class DeleteTask<BrowsingDataQuotaHelper>;
+
+  DISALLOW_COPY_AND_ASSIGN(BrowsingDataQuotaHelper);
+};
+
+bool operator <(const BrowsingDataQuotaHelper::QuotaInfo& lhs,
+                const BrowsingDataQuotaHelper::QuotaInfo& rhs);
+bool operator ==(const BrowsingDataQuotaHelper::QuotaInfo& lhs,

[kinuko, 2011/07/25 13:22:41]

Is this really necessary?  (Just asking)

[tzik, 2011/07/26 10:52:41]

We need it for
browsing_data_quota_helper_unittest.cc:111: EXPECT_TRUE(expected == actual);

+                const BrowsingDataQuotaHelper::QuotaInfo& rhs);
+
+#endif  // CHROME_BROWSER_BROWSING_DATA_QUOTA_HELPER_H_