Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8086)

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 7386002: Rename CommandLine::GetCommandLineString(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge, use writable string copies, restore TODO comment and empty string compare. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/install_worker.cc
diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc
index 717a869a46c64cd4da48bd885d3b975aac8e8e60..4eb70b725c29dd0aa678c726dfcf5beef222c1df 100644
--- a/chrome/installer/setup/install_worker.cc
+++ b/chrome/installer/setup/install_worker.cc
@@ -156,13 +156,13 @@ void AddUninstallShortcutWorkItems(const InstallerState& installer_state,
installer::kUninstallStringField, installer_path.value(), true);
install_list->AddSetRegValueWorkItem(reg_root, update_state_key,
installer::kUninstallArgumentsField,
- uninstall_arguments.command_line_string(), true);
+ uninstall_arguments.GetCommandLineString(), true);
// MSI installations will manage their own uninstall shortcuts.
if (!installer_state.is_msi() && product.ShouldCreateUninstallEntry()) {
// We need to quote the command line for the Add/Remove Programs dialog.
CommandLine quoted_uninstall_cmd(installer_path);
- DCHECK_EQ(quoted_uninstall_cmd.command_line_string()[0], '"');
+ DCHECK_EQ(quoted_uninstall_cmd.GetCommandLineString()[0], '"');
quoted_uninstall_cmd.AppendArguments(uninstall_arguments, false);
std::wstring uninstall_reg = browser_dist->GetUninstallRegPath();
@@ -172,7 +172,7 @@ void AddUninstallShortcutWorkItems(const InstallerState& installer_state,
browser_dist->GetAppShortCutName(), true);
install_list->AddSetRegValueWorkItem(reg_root,
uninstall_reg, installer::kUninstallStringField,
- quoted_uninstall_cmd.command_line_string(), true);
+ quoted_uninstall_cmd.GetCommandLineString(), true);
install_list->AddSetRegValueWorkItem(reg_root,
uninstall_reg,
L"InstallLocation",
@@ -565,7 +565,7 @@ bool AppendPostInstallTasks(const InstallerState& installer_state,
root,
version_key,
google_update::kRegRenameCmdField,
- product_rename_cmd.command_line_string(),
+ product_rename_cmd.GetCommandLineString(),
true);
}
@@ -861,17 +861,17 @@ void AddChromeFrameWorkItems(const InstallationState& original_state,
list->AddSetRegValueWorkItem(root, version_key,
google_update::kRegCFTempOptOutCmdField,
- temp_opt_out.command_line_string(), true);
+ temp_opt_out.GetCommandLineString(), true);
list->AddSetRegValueWorkItem(root, version_key,
google_update::kRegCFEndTempOptOutCmdField,
- end_temp_opt_out.command_line_string(),
+ end_temp_opt_out.GetCommandLineString(),
true);
list->AddSetRegValueWorkItem(root, version_key,
google_update::kRegCFOptOutCmdField,
- opt_out.command_line_string(), true);
+ opt_out.GetCommandLineString(), true);
list->AddSetRegValueWorkItem(root, version_key,
google_update::kRegCFOptInCmdField,
- opt_in.command_line_string(), true);
+ opt_in.GetCommandLineString(), true);
} else {
// If Chrome is not also being uninstalled, we need to update its command
// line so that it doesn't include uninstalling Chrome Frame now.
@@ -1169,7 +1169,7 @@ void AddQuickEnableWorkItems(const InstallerState& installer_state,
if (installer_state.verbose_logging())
cmd_line.AppendSwitch(switches::kVerboseLogging);
cmd_line.AppendSwitch(switches::kChromeFrameQuickEnable);
- AppCommand cmd(cmd_line.command_line_string(), true, true);
+ AppCommand cmd(cmd_line.GetCommandLineString(), true, true);
cmd.AddWorkItems(installer_state.root_key(), cmd_key, work_item_list);
} else {
DCHECK(operation == REMOVE_COMMAND);

Powered by Google App Engine
This is Rietveld 408576698