Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Side by Side Diff: chrome_frame/chrome_launcher_unittest.cc

Issue 7386002: Rename CommandLine::GetCommandLineString(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome_frame/chrome_frame_automation.cc ('k') | chrome_frame/chrome_tab.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/file_path.h" 6 #include "base/file_path.h"
7 #include "chrome/common/chrome_switches.h" 7 #include "chrome/common/chrome_switches.h"
8 #include "chrome_frame/chrome_launcher.h" 8 #include "chrome_frame/chrome_launcher.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 TEST(ChromeLauncher, IsValidCommandLine) { 11 TEST(ChromeLauncher, IsValidCommandLine) {
12 CommandLine bad(FilePath(L"dummy.exe")); 12 CommandLine bad(FilePath(L"dummy.exe"));
13 bad.AppendSwitch(switches::kNoFirstRun); // in whitelist 13 bad.AppendSwitch(switches::kNoFirstRun); // in whitelist
14 bad.AppendSwitch("no-such-switch"); // does not exist 14 bad.AppendSwitch("no-such-switch"); // does not exist
15 bad.AppendSwitch(switches::kHomePage); // exists but not in whitelist 15 bad.AppendSwitch(switches::kHomePage); // exists but not in whitelist
16 16
17 EXPECT_FALSE(chrome_launcher::IsValidCommandLine( 17 EXPECT_FALSE(chrome_launcher::IsValidCommandLine(
18 bad.command_line_string().c_str())); 18 bad.GetCommandLineString().c_str()));
19 19
20 CommandLine good(FilePath(L"dummy.exe")); 20 CommandLine good(FilePath(L"dummy.exe"));
21 good.AppendSwitch(switches::kNoFirstRun); // in whitelist 21 good.AppendSwitch(switches::kNoFirstRun); // in whitelist
22 good.AppendSwitchASCII(switches::kUserDataDir, "foo"); // in whitelist 22 good.AppendSwitchASCII(switches::kUserDataDir, "foo"); // in whitelist
23 23
24 EXPECT_TRUE(chrome_launcher::IsValidCommandLine( 24 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(
25 good.command_line_string().c_str())); 25 good.GetCommandLineString().c_str()));
26 26
27 CommandLine no_params(FilePath(L"dummy.exe")); 27 CommandLine no_params(FilePath(L"dummy.exe"));
28 EXPECT_TRUE(chrome_launcher::IsValidCommandLine( 28 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(
29 no_params.command_line_string().c_str())); 29 no_params.GetCommandLineString().c_str()));
30 30
31 CommandLine empty(FilePath(L"")); 31 CommandLine empty(FilePath(L""));
32 EXPECT_TRUE(chrome_launcher::IsValidCommandLine( 32 EXPECT_TRUE(chrome_launcher::IsValidCommandLine(
33 empty.command_line_string().c_str())); 33 empty.GetCommandLineString().c_str()));
34 } 34 }
35 35
36 TEST(ChromeLauncher, TrimWhiteSpace) { 36 TEST(ChromeLauncher, TrimWhiteSpace) {
37 std::wstring trimmed(chrome_launcher::TrimWhiteSpace(L" \t some text \n\t")); 37 std::wstring trimmed(chrome_launcher::TrimWhiteSpace(L" \t some text \n\t"));
38 EXPECT_STREQ(L"some text", trimmed.c_str()); 38 EXPECT_STREQ(L"some text", trimmed.c_str());
39 39
40 std::wstring now_empty(chrome_launcher::TrimWhiteSpace(L"\t\t \n\t")); 40 std::wstring now_empty(chrome_launcher::TrimWhiteSpace(L"\t\t \n\t"));
41 EXPECT_STREQ(L"", now_empty.c_str()); 41 EXPECT_STREQ(L"", now_empty.c_str());
42 42
43 std::wstring empty(chrome_launcher::TrimWhiteSpace(L"")); 43 std::wstring empty(chrome_launcher::TrimWhiteSpace(L""));
(...skipping 20 matching lines...) Expand all
64 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"chrome-frame")); 64 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"chrome-frame"));
65 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"-chrome-frame")); 65 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"-chrome-frame"));
66 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"---chrome-frame")); 66 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"---chrome-frame"));
67 EXPECT_FALSE(chrome_launcher::IsValidArgument(L" --chrome-frame")); 67 EXPECT_FALSE(chrome_launcher::IsValidArgument(L" --chrome-frame"));
68 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-framefoobar")); 68 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-framefoobar"));
69 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"foobar--chrome-frame")); 69 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"foobar--chrome-frame"));
70 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-frames")); 70 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-frames"));
71 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--Chrome-frame")); 71 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--Chrome-frame"));
72 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"")); 72 EXPECT_FALSE(chrome_launcher::IsValidArgument(L""));
73 } 73 }
OLDNEW
« no previous file with comments | « chrome_frame/chrome_frame_automation.cc ('k') | chrome_frame/chrome_tab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698