src/runtime.cc - Issue 7385006: Reintroduced dictionary that can use objects as keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 7385006: Reintroduced dictionary that can use objects as keys. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Incorporated review by Vitaly Repeshko. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index de8c6fddc4231e5579a8b2afa6dd1a6276c478e9..5783da75817a1e94d599207bf153bfaf523b60d9 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -4518,7 +4518,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_GetLocalPropertyNames) {

for (int i = 0; i < length; i++) {

jsproto->GetLocalPropertyNames(*names,

i == 0 ? 0 : local_property_count[i - 1]);

- if (!GetHiddenProperties(jsproto, false)->IsUndefined()) {

+ if (!GetHiddenProperties(jsproto, JSObject::OMIT_CREATION)->IsUndefined()) {

Vitaly Repeshko 2011/07/28 13:30:07 Maybe we need HasHiddenProperties to simplify this

Michael Starzinger 2011/07/28 17:19:47 Fixed

proto_with_hidden_properties++;

}

if (i < length - 1) {