Replace in-session header with auto-hide tool-bar.

Replace in-session header with auto-hide tool-bar.

BUG=None
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92746

[Jamie, 2011-07-15 18:25:15]

I've updated the in-session UI to comply with Ken's latest UI mocks. At present,
the Disconnect button is not implemented, so I've disabled it.

[Jamie, 2011-07-15 18:41:17]

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/remoting.js
File remoting/webapp/me2mom/remoting.js (right):

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting.js:481: * @return {void} Nothing.
Yes, I know this is stupid, but glint issues a warning if there's no
description...

[awong, 2011-07-15 19:41:16]

nice!

Couple of comments (only about 2 real ones)

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.html
File remoting/webapp/me2mom/choice.html (right):

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.h...
remoting/webapp/me2mom/choice.html:54: <div id="session-toolbar"
I started using "nav" elements for things like toolbars.  Neither change
control-panel to div, or change this to nav? (no opinion at all on which is
better).

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.h...
remoting/webapp/me2mom/choice.html:58: <span
id="session-status-message">Initialising...</span>
nice spelling. ;)

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.h...
remoting/webapp/me2mom/choice.html:59: <strong id="connected-to"></strong>
oooh.. a strong tag....cool.

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.h...
remoting/webapp/me2mom/choice.html:235: <div id="debug-log" hidden>
Should this be a section?

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/remoting.js
File remoting/webapp/me2mom/remoting.js (right):

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting.js:481: * @return {void} Nothing.
On 2011/07/15 18:41:17, Jamie wrote:
> Yes, I know this is stupid, but glint issues a warning if there's no
> description...

cute.  Slightly tempted to suggest replacing the description with ∅. :)

[Jamie, 2011-07-15 19:54:48]

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.html
File remoting/webapp/me2mom/choice.html (right):

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.h...
remoting/webapp/me2mom/choice.html:54: <div id="session-toolbar"
On 2011/07/15 19:41:16, awong wrote:
> I started using "nav" elements for things like toolbars.  Neither change
> control-panel to div, or change this to nav? (no opinion at all on which is
> better).

Since it's not used for navigation, I'm going to leave this one as a plain div.

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.h...
remoting/webapp/me2mom/choice.html:235: <div id="debug-log" hidden>
On 2011/07/15 19:41:16, awong wrote:
> Should this be a section?

Done.

[Jamie, 2011-07-15 20:37:29]

I've also given the 'connected to' element a maximum width, to prevent the
tool-bar overflowing. It's not perfect, but it should work for our use-case.

[awong, 2011-07-15 20:40:29]

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.html
File remoting/webapp/me2mom/choice.html (right):

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.h...
remoting/webapp/me2mom/choice.html:54: <div id="session-toolbar"
On 2011/07/15 19:54:48, Jamie wrote:
> On 2011/07/15 19:41:16, awong wrote:
> > I started using "nav" elements for things like toolbars.  Neither change
> > control-panel to div, or change this to nav? (no opinion at all on which is
> > better).
> 
> Since it's not used for navigation, I'm going to leave this one as a plain
div.

Should we change the control panel also to be a div then?

http://codereview.chromium.org/7383015/diff/7007/remoting/webapp/me2mom/toolb...
File remoting/webapp/me2mom/toolbar.css (right):

http://codereview.chromium.org/7383015/diff/7007/remoting/webapp/me2mom/toolb...
remoting/webapp/me2mom/toolbar.css:40: /* TODO(jamiewalch): This only works if
there are no spaces in the string */
Is this because we need to disable word wrapping?

http://www.w3schools.com/cssref/pr_text_white-space.asp

[Jamie, 2011-07-15 20:52:19]

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.html
File remoting/webapp/me2mom/choice.html (right):

http://codereview.chromium.org/7383015/diff/1/remoting/webapp/me2mom/choice.h...
remoting/webapp/me2mom/choice.html:54: <div id="session-toolbar"
On 2011/07/15 20:40:29, awong wrote:
> On 2011/07/15 19:54:48, Jamie wrote:
> > On 2011/07/15 19:41:16, awong wrote:
> > > I started using "nav" elements for things like toolbars.  Neither change
> > > control-panel to div, or change this to nav? (no opinion at all on which
is
> > > better).
> > 
> > Since it's not used for navigation, I'm going to leave this one as a plain
> div.
> 
> Should we change the control panel also to be a div then?

It will probably disappear in my next CL, but if it makes you happy, sure :)

http://codereview.chromium.org/7383015/diff/7007/remoting/webapp/me2mom/toolb...
File remoting/webapp/me2mom/toolbar.css (right):

http://codereview.chromium.org/7383015/diff/7007/remoting/webapp/me2mom/toolb...
remoting/webapp/me2mom/toolbar.css:40: /* TODO(jamiewalch): This only works if
there are no spaces in the string */
On 2011/07/15 20:40:29, awong wrote:
> Is this because we need to disable word wrapping?
> 
> http://www.w3schools.com/cssref/pr_text_white-space.asp

Yes! You rock!

[awong, 2011-07-15 20:57:37]

LGTM

Happy now.

http://codereview.chromium.org/7383015/diff/7007/remoting/webapp/me2mom/toolb...
File remoting/webapp/me2mom/toolbar.css (right):

http://codereview.chromium.org/7383015/diff/7007/remoting/webapp/me2mom/toolb...
remoting/webapp/me2mom/toolbar.css:40: /* TODO(jamiewalch): This only works if
there are no spaces in the string */
On 2011/07/15 20:52:20, Jamie wrote:
> On 2011/07/15 20:40:29, awong wrote:
> > Is this because we need to disable word wrapping?
> > 
> > http://www.w3schools.com/cssref/pr_text_white-space.asp
> 
> Yes! You rock!

Yay!

Comment is now stale btw..