Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 7383006: Make GYP build usable for day-to-day work (Closed)

Created:
9 years, 5 months ago by Jakob Kummerow
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make GYP build usable for day-to-day work - Introduce a global Makefile that triggers GYP-based building - Some fixes to .gyp[i] files to make everything work - tools/test-wrapper-gypbuild.py as a temporary solution for easy testing Committed: http://code.google.com/p/v8/source/detail?r=8674

Patch Set 1 #

Total comments: 2

Patch Set 2 : a few small fixes #

Patch Set 3 : fix autogenerated d8-js.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+526 lines, -95 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
A Makefile View 1 1 chunk +110 lines, -0 lines 0 comments Download
M build/all.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M build/armu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 2 chunks +18 lines, -4 lines 0 comments Download
M build/v8-features.gypi View 1 chunk +13 lines, -0 lines 0 comments Download
A + preparser/preparser.gyp View 1 1 chunk +12 lines, -7 lines 0 comments Download
M samples/samples.gyp View 2 chunks +10 lines, -9 lines 0 comments Download
M src/d8.gyp View 1 2 3 chunks +17 lines, -2 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/testcfg.py View 1 2 chunks +11 lines, -2 lines 0 comments Download
M test/preparser/testcfg.py View 1 chunk +6 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 20 chunks +93 lines, -67 lines 0 comments Download
M tools/test.py View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
A tools/test-wrapper-gypbuild.py View 1 1 chunk +223 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
Everyone: please take a look. Test it. Comment on it. Report issues. Complain about the ...
9 years, 5 months ago (2011-07-15 10:51:20 UTC) #1
Mads Ager (chromium)
LGTM
9 years, 5 months ago (2011-07-15 11:24:01 UTC) #2
mnaganov (inactive)
http://codereview.chromium.org/7383006/diff/1/preparser/preparser.gyp File preparser/preparser.gyp (right): http://codereview.chromium.org/7383006/diff/1/preparser/preparser.gyp#newcode29 preparser/preparser.gyp:29: #'target_defaults': { Do you need these commented out lines?
9 years, 5 months ago (2011-07-15 12:25:45 UTC) #3
Jakob Kummerow
9 years, 5 months ago (2011-07-15 12:29:54 UTC) #4
http://codereview.chromium.org/7383006/diff/1/preparser/preparser.gyp
File preparser/preparser.gyp (right):

http://codereview.chromium.org/7383006/diff/1/preparser/preparser.gyp#newcode29
preparser/preparser.gyp:29: #'target_defaults': {
On 2011/07/15 12:25:45, Mikhail Naganov (Chromium) wrote:
> Do you need these commented out lines?

Done.

Powered by Google App Engine
This is Rietveld 408576698