Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Unified Diff: chrome/browser/ui/webui/chromeos/login/oobe_ui.h

Issue 7382001: [ChromeOS] WebUI OOBE/Login refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync and address comments in set #1 Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/oobe_ui.h
diff --git a/chrome/browser/ui/webui/chromeos/login/oobe_ui.h b/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
index feb60bae2558b3e44051b29d3c12cfe7af539084..e688476956648f5867c05ec5c590aad5727eb94e 100644
--- a/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
+++ b/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
@@ -14,39 +14,12 @@ class DictionaryValue;
}
namespace chromeos {
+class BaseScreenHandler;
class SigninScreenHandler;
}
namespace chromeos {
-// Base class for the OOBE WebUI handlers.
-class OobeMessageHandler : public WebUIMessageHandler {
- public:
- OobeMessageHandler();
- virtual ~OobeMessageHandler();
-
- // Gets localized strings to be used on the page.
- virtual void GetLocalizedStrings(
- base::DictionaryValue* localized_strings) = 0;
-
- // This method is called when page is ready. It propagates to inherited class
- // via virtual Initialize() method (see below).
- void InitializeBase();
-
- protected:
- // Called when the page is ready and handler can do initialization.
- virtual void Initialize() = 0;
-
- // Whether page is ready.
- bool page_is_ready() const { return page_is_ready_; }
-
- private:
- // Keeps whether page is ready.
- bool page_is_ready_;
-
- DISALLOW_COPY_AND_ASSIGN(OobeMessageHandler);
-};
-
// A custom WebUI that defines datasource for out-of-box-experience (OOBE) UI:
// - welcome screen (setup language/keyboard/network).
// - eula screen (CrOS (+ OEM) EULA content/TPM password/crash reporting).
@@ -76,7 +49,7 @@ class OobeUI : public OobeDisplay,
void ShowSigninScreen();
private:
- void AddOobeMessageHandler(OobeMessageHandler* handler);
+ void AddScreenHandler(BaseScreenHandler* handler);
// Screens actors. Note, OobeUI owns them via |handlers_|, not directly here.
UpdateScreenActor* update_screen_actor_;

Powered by Google App Engine
This is Rietveld 408576698