Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/spaces.h

Issue 7379004: Add guard pages in front of platform allocations (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/platform.h ('K') | « src/platform-win32.cc ('k') | src/spaces.cc » ('j') | src/spaces.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/spaces.h
===================================================================
--- src/spaces.h (revision 8657)
+++ src/spaces.h (working copy)
@@ -645,13 +645,13 @@
// If a chunk has at least 16 pages, the maximum heap size is about
// 8K * 8K * 16 = 1G bytes.
#ifdef V8_TARGET_ARCH_X64
- static const int kPagesPerChunk = 32;
+ static const int kPagesPerChunk = 31;
// On 64 bit the chunk table consists of 4 levels of 4096-entry tables.
static const int kPagesPerChunkLog2 = 5;
Vyacheslav Egorov (Chromium) 2011/07/15 11:59:14 1 << kPagesPerChunkLog2 no longer equals to kPages
Cris Neckar 2011/07/15 18:51:29 Never fear.. This isn't used anywhere so I got rid
static const int kChunkTableLevels = 4;
static const int kChunkTableBitsPerLevel = 12;
#else
- static const int kPagesPerChunk = 16;
+ static const int kPagesPerChunk = 15;
// On 32 bit the chunk table consists of 2 levels of 256-entry tables.
static const int kPagesPerChunkLog2 = 4;
static const int kChunkTableLevels = 2;
« src/platform.h ('K') | « src/platform-win32.cc ('k') | src/spaces.cc » ('j') | src/spaces.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698