chrome/browser/safe_browsing/safe_browsing_test.cc - Issue 7377012: Change base::LaunchProcess API slightly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_test.cc

Issue 7377012: Change base::LaunchProcess API slightly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/safe_browsing_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_test.cc b/chrome/browser/safe_browsing/safe_browsing_test.cc

index 998fcb1a4d4c85880681e1630f0001acab11f305..9ee6b9affc9a878ab6440af7546eb4a110f0ddab 100644

--- a/chrome/browser/safe_browsing/safe_browsing_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_test.cc

@@ -149,8 +149,7 @@ class SafeBrowsingTestServer {

#if defined(OS_WIN)

options.start_hidden = true;

#endif

- options.process_handle = &server_handle_;

- if (!base::LaunchProcess(cmd_line, options)) {

+ if (!base::LaunchProcess(cmd_line, options, &server_handle_)) {

LOG(ERROR) << "Failed to launch server: "

<< cmd_line.command_line_string();

return false;