This change will split the result codes between content and chrome.

This change will split the result codes between content and chrome.

This adds a new file into chrome/common and does a lot of renaming.

The current version is just a sketch of the headers, and nothing will
compile.

R=jam@chromium.org
BUG=76699
TEST=everything still compiles and runs

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92730

[Dirk Pranke, 2011-07-14 22:38:36]

This more what you had in mind?

[jam, 2011-07-15 19:42:43]

lgtm with nits

http://codereview.chromium.org/7377010/diff/3001/chrome/browser/browser_main.cc
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/7377010/diff/3001/chrome/browser/browser_main....
chrome/browser/browser_main.cc:1558:
static_cast<int>(content::RESULT_CODE_NORMAL_EXIT) :
I don't think the casts are needed?

http://codereview.chromium.org/7377010/diff/3001/chrome/browser/browser_main_...
File chrome/browser/browser_main_win.cc (right):

http://codereview.chromium.org/7377010/diff/3001/chrome/browser/browser_main_...
chrome/browser/browser_main_win.cc:238: // the browser.
nit: this style of comments is not common in chrome, i.e. just put it all on one
line

[Dirk Pranke, 2011-07-15 20:02:22]

http://codereview.chromium.org/7377010/diff/3001/chrome/browser/browser_main.cc
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/7377010/diff/3001/chrome/browser/browser_main....
chrome/browser/browser_main.cc:1558:
static_cast<int>(content::RESULT_CODE_NORMAL_EXIT) :
On 2011/07/15 19:42:43, John Abd-El-Malek wrote:
> I don't think the casts are needed?

content::ResultCode and chrome::ResultCode are two different enum types; both
arms of the conditional expression have to be the same type, and the compiler
doesn't know how to automatically cast one to the other. (At least, I got a
compiler warning about this and it matches my understanding :). Dunno if there's
a better way to work around this.

http://codereview.chromium.org/7377010/diff/3001/chrome/browser/browser_main_...
File chrome/browser/browser_main_win.cc (right):

http://codereview.chromium.org/7377010/diff/3001/chrome/browser/browser_main_...
chrome/browser/browser_main_win.cc:238: // the browser.
On 2011/07/15 19:42:43, John Abd-El-Malek wrote:
> nit: this style of comments is not common in chrome, i.e. just put it all on
one
> line

Done.