Move download stuff from download helper back to TabContents. This is basically a revert of r8576...

chrome/browser/external_tab_container_win.h

Index: chrome/browser/external_tab_container_win.h
===================================================================
--- chrome/browser/external_tab_container_win.h	(revision 92629)
+++ chrome/browser/external_tab_container_win.h	(working copy)
@@ -16,7 +16,6 @@
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "chrome/browser/tab_contents/infobar_container.h"
 #include "chrome/browser/ui/blocked_content/blocked_content_tab_helper_delegate.h"
-#include "chrome/browser/ui/download/download_tab_helper_delegate.h"
 #include "chrome/browser/ui/views/frame/browser_bubble_host.h"
 #include "chrome/browser/ui/views/unhandled_keyboard_event_handler.h"
 #include "content/browser/tab_contents/tab_contents_delegate.h"
@@ -45,7 +44,6 @@
 // TabContents as well as an implementation of TabContentsDelegate.
 class ExternalTabContainer : public TabContentsDelegate,
                              public TabContentsObserver,
-                             public DownloadTabHelperDelegate,
                              public NotificationObserver,
                              public views::NativeWidgetWin,
                              public base::RefCounted<ExternalTabContainer>,
@@ -135,41 +133,26 @@
   virtual void UpdateTargetURL(TabContents* source, const GURL& url);
   virtual void ContentsZoomChange(bool zoom_in);
   virtual gfx::NativeWindow GetFrameNativeWindow();
-
   virtual bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
                                       bool* is_keyboard_shortcut);
   virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event);
-
   virtual bool TakeFocus(bool reverse);
-
+  virtual bool CanDownload(int request_id);
   virtual bool OnGoToEntryOffset(int offset);
-
   virtual void ShowPageInfo(Profile* profile,
                             const GURL& url,
                             const NavigationEntry::SSLStatus& ssl,
                             bool show_history);
-
-  // Handles the context menu display operation. This allows external
-  // hosts to customize the menu.

[Randy Smith (Not in Mondays), 2011/07/15 15:55:12]

Why eliminate the comments?

[jam, 2011/07/15 17:28:14]

this is duplicating the TabContentsDelegate comments. usual style is to only
have the comments on the interface, and not implementors

   virtual bool HandleContextMenu(const ContextMenuParams& params);
-
-  // Executes the context menu command identified by the command
-  // parameter.
   virtual bool ExecuteContextMenuCommand(int command);
-
   virtual void BeforeUnloadFired(TabContents* tab,
                                  bool proceed,
                                  bool* proceed_to_fire_unload);
-
-  virtual content::JavaScriptDialogCreator* GetJavaScriptDialogCreator()
-      OVERRIDE;
-
+  virtual content::JavaScriptDialogCreator* GetJavaScriptDialogCreator();
   void ShowRepostFormWarningDialog(TabContents* tab_contents);
-
   void RegisterRenderViewHost(RenderViewHost* render_view_host);
   void UnregisterRenderViewHost(RenderViewHost* render_view_host);
 
-
   // Overridden from TabContentsObserver:
   // IPC::Channel::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& message);
@@ -184,11 +167,6 @@
                        const NotificationSource& source,
                        const NotificationDetails& details);
 
-  // Overridden from DownloadTabHelperDelegate:
-  virtual bool CanDownload(int request_id) OVERRIDE;
-  virtual void OnStartDownload(DownloadItem* download,
-                               TabContentsWrapper* tab) OVERRIDE;
-
   // Returns the ExternalTabContainer instance associated with the cookie
   // passed in. It also erases the corresponding reference from the map.
   // Returns NULL if we fail to find the cookie in the map.