Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 7374008: Move download stuff from download helper back to TabContents. This is basically a revert of r8576... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 13 matching lines...) Expand all
24 #include "chrome/browser/sessions/session_id.h" 24 #include "chrome/browser/sessions/session_id.h"
25 #include "chrome/browser/sessions/tab_restore_service_observer.h" 25 #include "chrome/browser/sessions/tab_restore_service_observer.h"
26 #include "chrome/browser/sync/profile_sync_service_observer.h" 26 #include "chrome/browser/sync/profile_sync_service_observer.h"
27 #include "chrome/browser/tabs/tab_handler.h" 27 #include "chrome/browser/tabs/tab_handler.h"
28 #include "chrome/browser/tabs/tab_strip_model_delegate.h" // TODO(beng): remove 28 #include "chrome/browser/tabs/tab_strip_model_delegate.h" // TODO(beng): remove
29 #include "chrome/browser/tabs/tab_strip_model_observer.h" // TODO(beng): remove 29 #include "chrome/browser/tabs/tab_strip_model_observer.h" // TODO(beng): remove
30 #include "chrome/browser/ui/blocked_content/blocked_content_tab_helper_delegate. h" 30 #include "chrome/browser/ui/blocked_content/blocked_content_tab_helper_delegate. h"
31 #include "chrome/browser/ui/bookmarks/bookmark_bar.h" 31 #include "chrome/browser/ui/bookmarks/bookmark_bar.h"
32 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h" 32 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h"
33 #include "chrome/browser/ui/browser_navigator.h" 33 #include "chrome/browser/ui/browser_navigator.h"
34 #include "chrome/browser/ui/download/download_tab_helper_delegate.h"
35 #include "chrome/browser/ui/search_engines/search_engine_tab_helper_delegate.h" 34 #include "chrome/browser/ui/search_engines/search_engine_tab_helper_delegate.h"
36 #include "chrome/browser/ui/shell_dialogs.h" 35 #include "chrome/browser/ui/shell_dialogs.h"
37 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper_delegate.h" 36 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper_delegate.h"
38 #include "chrome/browser/ui/toolbar/toolbar_model.h" 37 #include "chrome/browser/ui/toolbar/toolbar_model.h"
39 #include "chrome/common/content_settings_types.h" 38 #include "chrome/common/content_settings_types.h"
40 #include "chrome/common/extensions/extension_constants.h" 39 #include "chrome/common/extensions/extension_constants.h"
41 #include "content/browser/debugger/devtools_toggle_action.h" 40 #include "content/browser/debugger/devtools_toggle_action.h"
42 #include "content/browser/tab_contents/page_navigator.h" 41 #include "content/browser/tab_contents/page_navigator.h"
43 #include "content/browser/tab_contents/tab_contents_delegate.h" 42 #include "content/browser/tab_contents/tab_contents_delegate.h"
44 #include "content/common/notification_registrar.h" 43 #include "content/common/notification_registrar.h"
(...skipping 18 matching lines...) Expand all
63 namespace gfx { 62 namespace gfx {
64 class Point; 63 class Point;
65 } 64 }
66 65
67 class Browser : public TabHandlerDelegate, 66 class Browser : public TabHandlerDelegate,
68 public TabContentsDelegate, 67 public TabContentsDelegate,
69 public TabContentsWrapperDelegate, 68 public TabContentsWrapperDelegate,
70 public SearchEngineTabHelperDelegate, 69 public SearchEngineTabHelperDelegate,
71 public BlockedContentTabHelperDelegate, 70 public BlockedContentTabHelperDelegate,
72 public BookmarkTabHelperDelegate, 71 public BookmarkTabHelperDelegate,
73 public DownloadTabHelperDelegate,
74 public PageNavigator, 72 public PageNavigator,
75 public CommandUpdater::CommandUpdaterDelegate, 73 public CommandUpdater::CommandUpdaterDelegate,
76 public NotificationObserver, 74 public NotificationObserver,
77 public SelectFileDialog::Listener, 75 public SelectFileDialog::Listener,
78 public TabRestoreServiceObserver, 76 public TabRestoreServiceObserver,
79 public ProfileSyncServiceObserver, 77 public ProfileSyncServiceObserver,
80 public InstantDelegate { 78 public InstantDelegate {
81 public: 79 public:
82 // SessionService::WindowType mirrors these values. If you add to this 80 // SessionService::WindowType mirrors these values. If you add to this
83 // enum, look at SessionService::WindowType to see if it needs to be 81 // enum, look at SessionService::WindowType to see if it needs to be
(...skipping 754 matching lines...) Expand 10 before | Expand all | Expand 10 after
838 virtual void TabContentsFocused(TabContents* tab_content) OVERRIDE; 836 virtual void TabContentsFocused(TabContents* tab_content) OVERRIDE;
839 virtual bool TakeFocus(bool reverse) OVERRIDE; 837 virtual bool TakeFocus(bool reverse) OVERRIDE;
840 virtual bool IsApplication() const OVERRIDE; 838 virtual bool IsApplication() const OVERRIDE;
841 virtual void ConvertContentsToApplication(TabContents* source) OVERRIDE; 839 virtual void ConvertContentsToApplication(TabContents* source) OVERRIDE;
842 virtual void BeforeUnloadFired(TabContents* source, 840 virtual void BeforeUnloadFired(TabContents* source,
843 bool proceed, 841 bool proceed,
844 bool* proceed_to_fire_unload) OVERRIDE; 842 bool* proceed_to_fire_unload) OVERRIDE;
845 virtual void SetFocusToLocationBar(bool select_all) OVERRIDE; 843 virtual void SetFocusToLocationBar(bool select_all) OVERRIDE;
846 virtual void RenderWidgetShowing() OVERRIDE; 844 virtual void RenderWidgetShowing() OVERRIDE;
847 virtual int GetExtraRenderViewHeight() const OVERRIDE; 845 virtual int GetExtraRenderViewHeight() const OVERRIDE;
846 virtual void OnStartDownload(DownloadItem* download,
847 TabContents* tab) OVERRIDE;
848 virtual void ShowPageInfo(Profile* profile, 848 virtual void ShowPageInfo(Profile* profile,
849 const GURL& url, 849 const GURL& url,
850 const NavigationEntry::SSLStatus& ssl, 850 const NavigationEntry::SSLStatus& ssl,
851 bool show_history) OVERRIDE; 851 bool show_history) OVERRIDE;
852 virtual void ViewSourceForTab(TabContents* source, 852 virtual void ViewSourceForTab(TabContents* source,
853 const GURL& page_url) OVERRIDE; 853 const GURL& page_url) OVERRIDE;
854 virtual void ViewSourceForFrame( 854 virtual void ViewSourceForFrame(
855 TabContents* source, 855 TabContents* source,
856 const GURL& frame_url, 856 const GURL& frame_url,
857 const std::string& frame_content_state) OVERRIDE; 857 const std::string& frame_content_state) OVERRIDE;
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
892 Profile* profile) OVERRIDE; 892 Profile* profile) OVERRIDE;
893 893
894 // Overridden from BlockedContentTabHelperDelegate: 894 // Overridden from BlockedContentTabHelperDelegate:
895 virtual TabContentsWrapper* GetConstrainingContentsWrapper( 895 virtual TabContentsWrapper* GetConstrainingContentsWrapper(
896 TabContentsWrapper* source) OVERRIDE; 896 TabContentsWrapper* source) OVERRIDE;
897 897
898 // Overridden from BookmarkTabHelperDelegate: 898 // Overridden from BookmarkTabHelperDelegate:
899 virtual void URLStarredChanged(TabContentsWrapper* source, 899 virtual void URLStarredChanged(TabContentsWrapper* source,
900 bool starred) OVERRIDE; 900 bool starred) OVERRIDE;
901 901
902 // Overridden from DownloadTabHelperDelegate:
903 virtual bool CanDownload(int request_id) OVERRIDE;
904 virtual void OnStartDownload(DownloadItem* download,
905 TabContentsWrapper* tab) OVERRIDE;
906
907
908 // Overridden from SelectFileDialog::Listener: 902 // Overridden from SelectFileDialog::Listener:
909 virtual void FileSelected(const FilePath& path, int index, void* params); 903 virtual void FileSelected(const FilePath& path, int index, void* params);
910 904
911 // Overridden from NotificationObserver: 905 // Overridden from NotificationObserver:
912 virtual void Observe(int type, 906 virtual void Observe(int type,
913 const NotificationSource& source, 907 const NotificationSource& source,
914 const NotificationDetails& details); 908 const NotificationDetails& details);
915 909
916 // Overridden from ProfileSyncServiceObserver: 910 // Overridden from ProfileSyncServiceObserver:
917 virtual void OnStateChanged(); 911 virtual void OnStateChanged();
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
1262 1256
1263 scoped_ptr<InstantController> instant_; 1257 scoped_ptr<InstantController> instant_;
1264 scoped_ptr<InstantUnloadHandler> instant_unload_handler_; 1258 scoped_ptr<InstantUnloadHandler> instant_unload_handler_;
1265 1259
1266 BookmarkBar::State bookmark_bar_state_; 1260 BookmarkBar::State bookmark_bar_state_;
1267 1261
1268 DISALLOW_COPY_AND_ASSIGN(Browser); 1262 DISALLOW_COPY_AND_ASSIGN(Browser);
1269 }; 1263 };
1270 1264
1271 #endif // CHROME_BROWSER_UI_BROWSER_H_ 1265 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698