Move download stuff from download helper back to TabContents. This is basically a revert of r8576...

Move download stuff from download helper back to TabContents. This is basically a revert of r85762, with updating for code changes in the meantime.

BUG=82782
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92747

[jam, 2011-07-15 00:08:55]

Timo: prerendering code
Scott: instant code
Randy: everything else

[jam, 2011-07-15 00:53:26]

http://codereview.chromium.org/7374008/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (left):

http://codereview.chromium.org/7374008/diff/1/chrome/browser/ui/browser.cc#ol...
chrome/browser/ui/browser.cc:3522: GetConstrainingContentsWrapper(tab) == tab &&
tab_count() > 1) {
btw I took out the "GetConstrainingContentsWrapper(tab) == tab" check. It was
added in r54737 but is now redundant, since GetConstrainingContentsWrapper(tab)
always returns tab now. I did verify that the bug which r54737 fixes is still
fixed.

[sky, 2011-07-15 15:23:56]

LGTM

[jam, 2011-07-15 15:47:30]

looks like the browser tests caught a bug because downloads aren't being
disabled for prerendering anymore. looking into it.

[Randy Smith (Not in Mondays), 2011-07-15 15:55:12]

John: This looks basically good, but I'm curious about something to improve my
baseline understanding of the goals.  It looks like the original change was
moving a lot of functionality from content into chrome.  Why was that necessary?
 Couldn't any accessors in chrome just reach into content as needed?  Or was it
a more general trying to create a clean interface between the two?

http://codereview.chromium.org/7374008/diff/10011/chrome/browser/external_tab...
File chrome/browser/external_tab_container_win.h (left):

http://codereview.chromium.org/7374008/diff/10011/chrome/browser/external_tab...
chrome/browser/external_tab_container_win.h:153: // hosts to customize the menu.
Why eliminate the comments?

[jam, 2011-07-15 17:28:14]

http://codereview.chromium.org/7374008/diff/10011/chrome/browser/external_tab...
File chrome/browser/external_tab_container_win.h (left):

http://codereview.chromium.org/7374008/diff/10011/chrome/browser/external_tab...
chrome/browser/external_tab_container_win.h:153: // hosts to customize the menu.
On 2011/07/15 15:55:12, rdsmith wrote:
> Why eliminate the comments?

this is duplicating the TabContentsDelegate comments. usual style is to only
have the comments on the interface, and not implementors

[jam, 2011-07-15 17:29:10]

On 2011/07/15 15:55:12, rdsmith wrote:
> John: This looks basically good, but I'm curious about something to improve my
> baseline understanding of the goals.  It looks like the original change was
> moving a lot of functionality from content into chrome.  Why was that
necessary?

At that time, we originally thought that download code would stay completely in
chrome. Afterwards we realized that it really belongs in content, since most
embedders will want this.

>  Couldn't any accessors in chrome just reach into content as needed?  Or was
it
> a more general trying to create a clean interface between the two?
> 
>
http://codereview.chromium.org/7374008/diff/10011/chrome/browser/external_tab...

[Randy Smith (Not in Mondays), 2011-07-15 18:03:43]

LGTM.

[tburkard, 2011-07-15 19:13:09]

On 2011/07/15 18:03:43, rdsmith wrote:
> LGTM.

LGTM