Issue 7373018: Workaround for bad driver issue with NVIDIA GeForce 7300 GT on Mac 10.5.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7373018: Workaround for bad driver issue with NVIDIA GeForce 7300 GT on Mac 10.5. (Closed)

Created:
9 years, 5 months ago by dmac

Modified:
9 years, 5 months ago

Reviewers:
jamiewalch, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Workaround for bad driver issue with NVIDIA GeForce 7300 GT on Mac 10.5. BUG=87283 TEST=Run on a machine with NVIDIA GeForce 7300 GT on Mac 10.5 immediately after booting. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92651

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	remoting/host/capturer_mac.cc	View		3 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jamiewalch

9 years, 5 months ago (2011-07-15 00:47:28 UTC) #2

LGTM

On Thu, Jul 14, 2011 at 5:07 PM,  <dmaclach@chromium.org> wrote:
> Reviewers: Jamie,
>
> Message:
> PTAL
>
> Description:
> Workaround for bad driver issue with NVIDIA GeForce 7300 GT on Mac 10.5.
>
>
> BUG=87283
> TEST=Run on a machine with NVIDIA GeForce 7300 GT on Mac 10.5 immediately
> after
> booting.
>
>
> Please review this at http://codereview.chromium.org/7373018/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M remoting/host/capturer_mac.cc
>
>
> Index: remoting/host/capturer_mac.cc
> diff --git a/remoting/host/capturer_mac.cc b/remoting/host/capturer_mac.cc
> index
>
c507858b1748cff76b331b56b593d014d1ebcaea..cf1cfe76075f3ba03792d98e2fa278443d700455
> 100644
> --- a/remoting/host/capturer_mac.cc
> +++ b/remoting/host/capturer_mac.cc
> @@ -11,6 +11,7 @@
>  #include <stddef.h>
>
>  #include "base/logging.h"
> +#include "base/mac/mac_util.h"
>  #include "base/memory/scoped_ptr.h"
>  #include "remoting/host/capturer_helper.h"
>
> @@ -46,6 +47,13 @@ scoped_pixel_buffer_object::~scoped_pixel_buffer_object()
> {
>
>  bool scoped_pixel_buffer_object::Init(CGLContextObj cgl_context,
>                                       int size_in_bytes) {
> +  // The PBO path is only done on 10.6 (SnowLeopard) and above due to
> +  // a driver issue that was found on 10.5
> +  // (specifically on a NVIDIA GeForce 7300 GT).
> +  // http://crbug.com/87283
> +  if (base::mac::IsOSLeopardOrEarlier()) {
> +    return false;
> +  }
>   cgl_context_ = cgl_context;
>   CGLContextObj CGL_MACRO_CONTEXT = cgl_context_;
>   glGenBuffersARB(1, &pixel_buffer_object_);
> @@ -297,6 +305,8 @@ void
> CapturerMac::CaptureInvalidRects(CaptureCompletedCallback* callback) {
>       if (pixel_buffer_object_.get() != 0) {
>         GlBlitFast(current_buffer);
>       } else {
> +        // See comment in scoped_pixel_buffer_object::Init about why the
> slow
> +        // path is always used on 10.5.
>         GlBlitSlow(current_buffer);
>       }
>     } else {
>
>
>

Expand Messages | Collapse Messages