When the chrome window is maximized, make sure the new tab button extends

When the chrome window is maximized, make sure the new tab button extends
right to the top of the screen.

BUG=48727
TEST=When the chrome window is maximized, you should be able to click on the
area above the new tab button, and it should create a new tab.  When the
window is not maximized, you need to click in the visible portion of the
button to create a new tab.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92738

[sky, 2011-07-14 19:51:08]

http://codereview.chromium.org/7373006/diff/1/chrome/browser/ui/views/tabs/ta...
File chrome/browser/ui/views/tabs/tab_strip.h (right):

http://codereview.chromium.org/7373006/diff/1/chrome/browser/ui/views/tabs/ta...
chrome/browser/ui/views/tabs/tab_strip.h:43: explicit TabStrip(Browser* browser,
TabStripController* controller);
TabStrip shouldn't depend on browser. Move the conditional into
TabStripController and BrowserTabStripController.

[Roger Tawa OOO till Jul 10th, 2011-07-14 20:23:49]

Thanks Scott, much better as you suggest.  Changes uploaded, please  take
another look.

[sky, 2011-07-14 20:38:20]

LGTM

http://codereview.chromium.org/7373006/diff/11001/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab_strip.cc (right):

http://codereview.chromium.org/7373006/diff/11001/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab_strip.cc:80: : views::ImageButton(listener),
tab_strip_(tab_strip) {
When you can't fit all the initializers on a single line, then each should go on
its own line.

http://codereview.chromium.org/7373006/diff/11001/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab_strip.cc:582: bool
TabStrip::SizeTabButtonToTopOfTabStrip() {
Make position match position in header.

http://codereview.chromium.org/7373006/diff/11001/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab_strip.h (right):

http://codereview.chromium.org/7373006/diff/11001/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab_strip.h:143: void InitTabStripButtons();
Move the implementation to match the new position.

[Roger Tawa OOO till Jul 10th, 2011-07-14 21:09:28]

Thanks Scott.  Comments addressed, changes uploaded.  Will wait for trybots
before committing.

http://codereview.chromium.org/7373006/diff/11001/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab_strip.cc (right):

http://codereview.chromium.org/7373006/diff/11001/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab_strip.cc:80: : views::ImageButton(listener),
tab_strip_(tab_strip) {
On 2011/07/14 20:38:20, sky wrote:
> When you can't fit all the initializers on a single line, then each should go
on
> its own line.

Done.

http://codereview.chromium.org/7373006/diff/11001/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab_strip.cc:582: bool
TabStrip::SizeTabButtonToTopOfTabStrip() {
On 2011/07/14 20:38:20, sky wrote:
> Make position match position in header.

Done.

http://codereview.chromium.org/7373006/diff/11001/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab_strip.h (right):

http://codereview.chromium.org/7373006/diff/11001/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab_strip.h:143: void InitTabStripButtons();
On 2011/07/14 20:38:20, sky wrote:
> Move the implementation to match the new position.

Done.

[commit-bot: I haz the power, 2011-07-15 21:31:23]

Change committed as 92738