Issue 7371006: Fix gyp build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7371006: Fix gyp build (Closed)

Created:
9 years, 5 months ago by Jakob Kummerow

Modified:
9 years, 5 months ago

Reviewers:
mnaganov (inactive), Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix gyp build by replicating changes to SConscript from r8654 to cctest.gyp TEST=cctest compiles with gyp/make. Committed: http://code.google.com/p/v8/source/detail?r=8658

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -2 lines)			Patch
	M	build/all.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	test/cctest/cctest.gyp	View		3 chunks	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

On 2011/07/14 15:55:28, jkummerow wrote: > PTAL. My fault. Thanks for fixing this!

9 years, 5 months ago (2011-07-14 16:37:51 UTC) #2

mnaganov (inactive)

On 2011/07/14 16:37:51, Mikhail Naganov (Chromium) wrote: > On 2011/07/14 15:55:28, jkummerow wrote: > > ...

9 years, 5 months ago (2011-07-14 16:38:07 UTC) #3

Yang

9 years, 5 months ago (2011-07-15 08:08:35 UTC) #4

LGTM.

cctest still failing tests, but at least compiling. Checking this out currently

On 2011/07/14 16:38:07, Mikhail Naganov (Chromium) wrote:
> On 2011/07/14 16:37:51, Mikhail Naganov (Chromium) wrote:
> > On 2011/07/14 15:55:28, jkummerow wrote:
> > > PTAL.
> > 
> > My fault. Thanks for fixing this!
> 
> LGTM

Expand Messages | Collapse Messages