Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 737001: Add support for testing the touch event mechanism to test_shell. (Closed)

Created:
10 years, 9 months ago by Garret Kelly
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Add support for testing the touch event mechanism to test_shell. BUG=36415 TEST=fast/events/touch Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41619

Patch Set 1 #

Patch Set 2 : Minor style fix #

Total comments: 4

Patch Set 3 : Review fixes #

Patch Set 4 : ENABLE_TOUCH_EVENTS=1 belongs in features.gypi #

Patch Set 5 : Disabling tests pending WebKit patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -0 lines) Patch
M webkit/tools/test_shell/event_sending_controller.h View 2 chunks +14 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/event_sending_controller.cc View 1 2 7 chunks +153 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
darin (slow to review)
LGTM w/ nits fixed http://codereview.chromium.org/737001/diff/4001/5003 File webkit/tools/test_shell/event_sending_controller.cc (right): http://codereview.chromium.org/737001/diff/4001/5003#newcode873 webkit/tools/test_shell/event_sending_controller.cc:873: NOTREACHED() << L"Invalid touch point ...
10 years, 9 months ago (2010-03-09 19:04:09 UTC) #1
Garret Kelly
On 2010/03/09 19:04:09, darin wrote: > LGTM w/ nits fixed > > http://codereview.chromium.org/737001/diff/4001/5003 > File ...
10 years, 9 months ago (2010-03-09 19:10:30 UTC) #2
darin (slow to review)
> All done. PTAL? It looks like the try bots were not happy with this ...
10 years, 9 months ago (2010-03-09 23:54:31 UTC) #3
tony
BTW, test_shell is eventually going away and we're moving the code for event_sending_controller upstream to ...
10 years, 9 months ago (2010-03-10 00:31:16 UTC) #4
tkent
> BTW, test_shell is eventually going away and we're moving the code for > event_sending_controller ...
10 years, 9 months ago (2010-03-10 01:11:16 UTC) #5
darin (slow to review)
10 years, 9 months ago (2010-03-10 05:20:21 UTC) #6
Sorry for not sending you a heads up about this change.

-Darin


On Tue, Mar 9, 2010 at 5:11 PM, <tkent@chromium.org> wrote:

> BTW, test_shell is eventually going away and we're moving the code for
>> event_sending_controller upstream to
>> WebKitTools/DumpRenderTree/chromium/EventSender.*.  I don't have a general
>>
> plan
>
>> for how this is going to work during the transition, but we should be
>> careful
>> not to drop patches like this when migrating.
>>
>
> I'm tracking what revision the DRT/Chromium is based on.  So it's still ok
> to
> change test_shell code.
> I had better send a notice about this to chromium-dev.
>
>
>
> http://codereview.chromium.org/737001
>

Powered by Google App Engine
This is Rietveld 408576698