Issue 7369001: Implement delete trap for proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7369001: Implement delete trap for proxies. (Closed)

Created:
9 years, 5 months ago by rossberg

Modified:
9 years, 5 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Implement delete trap for proxies. R=ager@chromium.org BUG=1543 TEST= Committed: http://code.google.com/p/v8/source/detail?r=8660

Patch Set 2 : Addressed Mads' comments. #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -34 lines)			Patch
M	src/objects.h	View		4 chunks	+15 lines, -9 lines	0 comments	Download
M	src/objects.cc	View	1	12 chunks	+60 lines, -13 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View		5 chunks	+12 lines, -11 lines	0 comments	Download
M	test/mjsunit/harmony/proxies.js	View		1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/7369001/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/7369001/diff/1/src/objects.cc#newcode2239 src/objects.cc:2239: HandleScope scope; You should pass in the isolate ...

9 years, 5 months ago (2011-07-14 16:17:22 UTC) #2

rossberg

9 years, 5 months ago (2011-07-15 08:47:40 UTC) #3

http://codereview.chromium.org/7369001/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7369001/diff/1/src/objects.cc#newcode2239
src/objects.cc:2239: HandleScope scope;
On 2011/07/14 16:17:22, Mads Ager wrote:
> You should pass in the isolate to the HandleScope constructor so it will not
go
> through thread-local storage to get it.

Done, here and in a number of other places.

http://codereview.chromium.org/7369001/diff/1/src/objects.cc#newcode2263
src/objects.cc:2263: if (mode != NORMAL_DELETION && bool_result ==
GetHeap()->false_value()) {
On 2011/07/14 16:17:22, Mads Ager wrote:
> Do we want this behavior for FORCE_DELETION as well? I would have guessed that
> the test should be mode == STRICT_DELETION?

Done.

Expand Messages | Collapse Messages

Issue 7369001: Implement delete trap for proxies. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed Mads' comments. #

Messages